You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by tv...@apache.org on 2013/02/21 17:05:29 UTC
git commit: [#5658] Fix redirect and path validation
Updated Branches:
refs/heads/tv/5658 d3744f9a8 -> 1d1ed8a81
[#5658] Fix redirect and path validation
Project: http://git-wip-us.apache.org/repos/asf/incubator-allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-allura/commit/1d1ed8a8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-allura/tree/1d1ed8a8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-allura/diff/1d1ed8a8
Branch: refs/heads/tv/5658
Commit: 1d1ed8a81b9d9eec77c8d8844678306be32a0846
Parents: d3744f9
Author: Tim Van Steenburgh <tv...@gmail.com>
Authored: Thu Feb 21 16:05:10 2013 +0000
Committer: Tim Van Steenburgh <tv...@gmail.com>
Committed: Thu Feb 21 16:05:10 2013 +0000
----------------------------------------------------------------------
Allura/allura/controllers/site_admin.py | 2 +-
Allura/allura/lib/validators.py | 2 +-
Allura/allura/tests/test_validators.py | 5 ++++-
3 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/1d1ed8a8/Allura/allura/controllers/site_admin.py
----------------------------------------------------------------------
diff --git a/Allura/allura/controllers/site_admin.py b/Allura/allura/controllers/site_admin.py
index 7bb2c5d..096aba7 100644
--- a/Allura/allura/controllers/site_admin.py
+++ b/Allura/allura/controllers/site_admin.py
@@ -328,7 +328,7 @@ class TaskManagerController(object):
config_dict['user'] = user
with h.push_config(c, **config_dict):
task = task.post(*args, **kw)
- redirect('view', task_id=task._id)
+ redirect('view/%s' % task._id)
@expose('json:')
def task_doc(self, task_name):
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/1d1ed8a8/Allura/allura/lib/validators.py
----------------------------------------------------------------------
diff --git a/Allura/allura/lib/validators.py b/Allura/allura/lib/validators.py
index de6bf51..5c4c54e 100644
--- a/Allura/allura/lib/validators.py
+++ b/Allura/allura/lib/validators.py
@@ -138,7 +138,7 @@ class CreateTaskSchema(fe.Schema):
task = TaskValidator(not_empty=True, strip=True)
task_args = JsonConverter(if_missing=dict(args=[], kwargs={}))
user = UserValidator(strip=True, if_missing=None)
- path = PathValidator(strip=True, if_missing={})
+ path = PathValidator(strip=True, if_missing={}, if_empty={})
class DateValidator(fev.FancyValidator):
def _to_python(self, value, state):
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/1d1ed8a8/Allura/allura/tests/test_validators.py
----------------------------------------------------------------------
diff --git a/Allura/allura/tests/test_validators.py b/Allura/allura/tests/test_validators.py
index 5472e2d..95f48ef 100644
--- a/Allura/allura/tests/test_validators.py
+++ b/Allura/allura/tests/test_validators.py
@@ -67,7 +67,7 @@ class TestTaskValidator(unittest.TestCase):
class TestPathValidator(unittest.TestCase):
- val = v.PathValidator
+ val = v.PathValidator(strip=True, if_missing={}, if_empty={})
def test_valid_project(self):
project = M.Project.query.get(shortname='test')
@@ -102,3 +102,6 @@ class TestPathValidator(unittest.TestCase):
with self.assertRaises(fe.Invalid) as cm:
self.val.to_python('/p/test/badapp')
self.assertEqual(str(cm.exception), 'Invalid app mount point: badapp')
+
+ def test_no_input(self):
+ self.assertEqual({}, self.val.to_python(''))