You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/14 08:18:58 UTC
[GitHub] [streampipes] tenthe opened a new pull request, #1093: Sp 1085
tenthe opened a new pull request, #1093:
URL: https://github.com/apache/streampipes/pull/1093
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
Fixes #1085.
Previously, the `FileStreamProtocol` required another sink (`SendToBrokerReplayAdapterSink`) for the adapter preprocessing pipeline.
The reason for this was that the `FileStreamProtocol` needs to adjust the timestamp for correct replay, but it was the only adapter / protocol that used a different sink.
The `SendToBrokerReplayAdapterSink` class was deleted and the code was moved directly to the `FileStreamProtocol`.
Further, some minor refactoring was performed.
This should not be the final rewrite of the protocol, it is just a clean up step to better refactor the connect api.
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1093: Sp 1085
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #1093:
URL: https://github.com/apache/streampipes/pull/1093#discussion_r1071447000
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/model/pipeline/AdapterEventPreviewPipeline.java:
##########
@@ -79,4 +80,9 @@ public Map<String, GuessTypeInfo> makePreview() {
.collect(Collectors.toMap(Map.Entry::getKey,
e -> new GuessTypeInfo(e.getValue().getClass().getCanonicalName(), e.getValue())));
}
+
+ @Override
+ public EventSchema getResultingEventSchema() {
+ return null;
Review Comment:
Why does this method always return null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe commented on a diff in pull request #1093: Sp 1085
Posted by GitBox <gi...@apache.org>.
tenthe commented on code in PR #1093:
URL: https://github.com/apache/streampipes/pull/1093#discussion_r1071456267
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/model/pipeline/AdapterEventPreviewPipeline.java:
##########
@@ -79,4 +80,9 @@ public Map<String, GuessTypeInfo> makePreview() {
.collect(Collectors.toMap(Map.Entry::getKey,
e -> new GuessTypeInfo(e.getValue().getClass().getCanonicalName(), e.getValue())));
}
+
+ @Override
+ public EventSchema getResultingEventSchema() {
+ return null;
Review Comment:
This is only temporary. In the future we probably will replace the class `AdapterEventPreviewPipeline` with a regular `AdapterPipeline` that uses a different sink.
I had to add it here to remove the dependency of the `FileStreamProtocol` with the internal adapter implementation.
If you have an idea on how to remove it, I'm happy to discuss it. If there is no quick solution, I would suggest to leave it as it is and remove it during the revision of the connect API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe merged pull request #1093: Sp 1085
Posted by GitBox <gi...@apache.org>.
tenthe merged PR #1093:
URL: https://github.com/apache/streampipes/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org