You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Gary Tully (Jira)" <ji...@apache.org> on 2020/07/17 10:38:00 UTC
[jira] [Commented] (ARTEMIS-2849) Eliminate zeroing of buffers
while writing the journal
[ https://issues.apache.org/jira/browse/ARTEMIS-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159858#comment-17159858 ]
Gary Tully commented on ARTEMIS-2849:
-------------------------------------
verify on recovery, if reading zeros is part of EOF determination (ie: not depending on the size attribute of a file). I suspect the zeroing of the buffer is ensuring that no cruft exists after the last record. Just a thought!
> Eliminate zeroing of buffers while writing the journal
> ------------------------------------------------------
>
> Key: ARTEMIS-2849
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2849
> Project: ActiveMQ Artemis
> Issue Type: Test
> Components: Broker
> Reporter: Francesco Nigro
> Priority: Major
>
> By default ASYNCIO, NIO and MAPPED journal while using TimedBuffer are zeroing the ByteBuffers used to perform the write on the journal: under load TimedBuffer can be big enough that zeroing would cost the same as copying the actual content into it, hence saving the zeroing is quite beneficial to save CPU time and increase IOPS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)