[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #840: [KYUUBI #839]Fix load user specific defaults from properties file

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #840:
URL: https://github.com/apache/incubator-kyuubi/pull/840#discussion_r673020501



##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/config/KyuubiConfSuite.scala
##########
@@ -97,17 +97,13 @@ class KyuubiConfSuite extends KyuubiFunSuite {
 
 
   test("get user specific defaults") {
-    val conf = KyuubiConf(false)
-      .set("spark.user.test", "a")
-      .set("___userb___.spark.user.test", "b")
-      .set("___userc___.spark.user.test", "c")
-
-    val all1 = conf.getUserDefaults("kyuubi").getAll
-    assert(all1.size === 1)
-    assert(all1("spark.user.test") === "a")
-    val all2 = conf.getUserDefaults("userb").getAll
-    assert(all2.size === 1)
-    assert(all2("spark.user.test") === "b")
+    sys.props.put("spark.user.test", "a")

Review comment:
       can we add a file in test resource？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org