[GitHub] [systemds] j143 commented on pull request #1026: [MINOR] Added leaky relu layer + grad check and updated 2NN example

[GitBox <gi...@apache.org>]

j143 commented on pull request #1026:
URL: https://github.com/apache/systemds/pull/1026#issuecomment-675005848


   Hi @tobiasrieger - Thanks a lot for contributing deep learning examples.
   
   **TL;DR:** Providing more info would be easier to review the changes! 😄 
   
   1. [New feature guideline](https://github.com/apache/systemds/blob/master/CONTRIBUTING.md#general-guidelines-and-philosophy-for-contribution)
   
   "New features (e.g., **a new cutting edge machine learning algorithm**) typically will live in scripts/staging or its equivalent folder for specific feature to get **some airtime** and **sufficient testing** before a decision is made regarding whether they are to migrated to the top-level."
   
   2. The end goal is to make sure the contributions will add a base for further research.
   For this reason, try adding any
       - reference papers,
       - docs,
       - articles
       - screenshots
       - rationale
   
   An example [documentation](https://github.com/apache/systemds/blob/master/src/main/python/docs/source/onnx_systemds/onnx_systemds_design.rst#design).
   
   Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org