You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/19 13:11:20 UTC

[GitHub] [shardingsphere] huanghao495430759 opened a new pull request #9749: Fix issues#9510 , support rewrite SQL correctly when using sharding and encrypt together

huanghao495430759 opened a new pull request #9749:
URL: https://github.com/apache/shardingsphere/pull/9749


   Fixes #9510.
   -refactor SubstitutableColumnNameToken to SubstitutableColumnsToken,support rewrite SQL correctly when using sharding and encrypt together.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io commented on pull request #9749: Fix issues#9510 , support rewrite SQL correctly when using sharding and encrypt together

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9749:
URL: https://github.com/apache/shardingsphere/pull/9749#issuecomment-803589177


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=h1) Report
   > Merging [#9749](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=desc) (f570243) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dc53bdb803018d00baac0f2cb0efb2f333da43e8?el=desc) (dc53bdb) will **decrease** coverage by `0.02%`.
   > The diff coverage is `54.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9749/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9749      +/-   ##
   ============================================
   - Coverage     67.72%   67.70%   -0.03%     
   + Complexity      681      679       -2     
   ============================================
     Files          1663     1664       +1     
     Lines         27641    27673      +32     
     Branches       4891     4906      +15     
   ============================================
   + Hits          18720    18735      +15     
   - Misses         7542     7558      +16     
   - Partials       1379     1380       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/shardingsphere/infra/audit/SQLCheckEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hdWRpdC9TUUxDaGVja0VuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...or/sql/prepare/AbstractExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL0Fic3RyYWN0RXhlY3V0aW9uUHJlcGFyZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...l/prepare/driver/DriverExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9Ecml2ZXJFeGVjdXRpb25QcmVwYXJlRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...te/sql/token/pojo/generic/SubstitutableColumn.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...here/proxy/frontend/state/impl/LockProxyState.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvc3RhdGUvaW1wbC9Mb2NrUHJveHlTdGF0ZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...mmon/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2l0ZW0vQ29sdW1uUHJvamVjdGlvblNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/infra/rewrite/sql/impl/AbstractSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvaW1wbC9BYnN0cmFjdFNRTEJ1aWxkZXIuamF2YQ==) | `48.38% <21.05%> (-38.28%)` | `0.00 <0.00> (ø)` | |
   | [.../token/pojo/generic/SubstitutableColumnsToken.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW5zVG9rZW4uamF2YQ==) | `31.57% <31.57%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ingsphere/governance/core/lock/GovernanceLock.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL0dvdmVybmFuY2VMb2NrLmphdmE=) | `61.53% <50.00%> (+19.87%)` | `0.00 <0.00> (ø)` | |
   | [...ce/core/registry/listener/LockChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9saXN0ZW5lci9Mb2NrQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `44.44% <50.00%> (-44.45%)` | `0.00 <0.00> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/9749/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=footer). Last update [581419b...f570243](https://codecov.io/gh/apache/shardingsphere/pull/9749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #9749: Fix issues#9510 , support rewrite SQL correctly when using sharding and encrypt together

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #9749:
URL: https://github.com/apache/shardingsphere/pull/9749


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org