You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/11 19:58:07 UTC

[GitHub] [geode] nonbinaryprogrammer opened a new pull request #5841: GEODE-8766: reduce collisions during hget in AbstractHashesIntegrationTest

nonbinaryprogrammer opened a new pull request #5841:
URL: https://github.com/apache/geode/pull/5841


   In AbstractHashesIntegrationTest putting the value would fail in the test setup. It was using a pseudo-random method to generate keys. That method was not random enough and was causing collisions, making the put fail. This in turn caused the number of keys to be incorrect so the test would never hget all the keys it was expecting.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] nonbinaryprogrammer merged pull request #5841: GEODE-8766: reduce collisions during hget in AbstractHashesIntegrationTest

Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer merged pull request #5841:
URL: https://github.com/apache/geode/pull/5841


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org