You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/31 05:21:35 UTC
[GitHub] [pulsar] Technoboy- commented on a change in pull request #14949: [fix][broker] Fix creating system namespace topic failure.
Technoboy- commented on a change in pull request #14949:
URL: https://github.com/apache/pulsar/pull/14949#discussion_r839179670
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2836,7 +2836,8 @@ public boolean isAllowAutoTopicCreation(final String topic) {
public boolean isAllowAutoTopicCreation(final TopicName topicName) {
//System topic can always be created automatically
- if (pulsar.getConfiguration().isSystemTopicEnabled() && checkTopicIsEventsNames(topicName)) {
+ if ((pulsar.getConfiguration().isSystemTopicEnabled() && checkTopicIsEventsNames(topicName))
Review comment:
yes, right.
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2836,7 +2836,8 @@ public boolean isAllowAutoTopicCreation(final String topic) {
public boolean isAllowAutoTopicCreation(final TopicName topicName) {
//System topic can always be created automatically
- if (pulsar.getConfiguration().isSystemTopicEnabled() && checkTopicIsEventsNames(topicName)) {
+ if ((pulsar.getConfiguration().isSystemTopicEnabled() && checkTopicIsEventsNames(topicName))
Review comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org