You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Vladsz83 (via GitHub)" <gi...@apache.org> on 2026/03/13 23:23:17 UTC
[PR] IGNITE-28200 - Use MarshalableMessage for Communication messages v2 [ignite]
Vladsz83 opened a new pull request, #12891:
URL: https://github.com/apache/ignite/pull/12891
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12891:
URL: https://github.com/apache/ignite/pull/12891#issuecomment-4091360173
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java`
- `modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #12891:
URL: https://github.com/apache/ignite/pull/12891#discussion_r2953254111
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
@@ -2054,9 +2047,6 @@ else if (async)
ackC.apply(null);
}
else {
- if (topicOrd < 0)
Review Comment:
This condition also should be taken into account in #prepareMarshal.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
Review Comment:
It seems that `if` block can be removed, and code of `topic` initialization should be completely placed intoto `#finishUnmarshall`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
Review Comment:
It seems that `if` block can be removed, and code of `topic` initialization should be completely placed intoto `#finishUnmarshall`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
@@ -1980,9 +1976,6 @@ private IgniteInternalFuture<Channel> openChannel(
);
try {
- if (topicOrd < 0)
Review Comment:
This condition also should be taken into account in `#prepareMarshal`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -219,31 +217,33 @@ public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
evtsBytes = U.marshal(marsh, evts);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- * @param filterClsLdr Class loader for filter.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr, ClassLoader filterClsLdr) throws IgniteCheckedException {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr) throws IgniteCheckedException {
if (resTopicBytes != null && resTopic == null) {
resTopic = U.unmarshal(marsh, resTopicBytes, ldr);
resTopicBytes = null;
}
- if (filterBytes != null && filter == null && filterClsLdr != null) {
Review Comment:
`filterClsLdr != null` we are missing this condition now. But can it be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28200 - Use MarshalableMessage for Communication messages v2 [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12891:
URL: https://github.com/apache/ignite/pull/12891#issuecomment-4058667022
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java`
- `modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentRequest.java`
- `modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12891:
URL: https://github.com/apache/ignite/pull/12891#issuecomment-4091843475
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java`
- `modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov merged PR #12891:
URL: https://github.com/apache/ignite/pull/12891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12891:
URL: https://github.com/apache/ignite/pull/12891#issuecomment-4091854258
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12891) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12891&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12891&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=12891&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12891&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12891&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12891)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #12891:
URL: https://github.com/apache/ignite/pull/12891#discussion_r2953045351
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
Review Comment:
It seems that `if` block can be removed, and code of `topic` initialization should be completely placed into `#finishUnmarshall`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
Review Comment:
It seems that `if` block can be removed, and code of `topic` initialization should be completely placed into `#finishUnmarshall`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "Vladsz83 (via GitHub)" <gi...@apache.org>.
Vladsz83 commented on code in PR #12891:
URL: https://github.com/apache/ignite/pull/12891#discussion_r2958115380
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -219,31 +217,33 @@ public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
evtsBytes = U.marshal(marsh, evts);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- * @param filterClsLdr Class loader for filter.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr, ClassLoader filterClsLdr) throws IgniteCheckedException {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr) throws IgniteCheckedException {
if (resTopicBytes != null && resTopic == null) {
resTopic = U.unmarshal(marsh, resTopicBytes, ldr);
resTopicBytes = null;
}
- if (filterBytes != null && filter == null && filterClsLdr != null) {
Review Comment:
No. Now cannot be null (not expected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28286 : Use MarshallableMessage for GridIoMessage and GridEventStorageMessage v2 [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #12891:
URL: https://github.com/apache/ignite/pull/12891#discussion_r2960736184
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java:
##########
@@ -216,24 +218,21 @@ public int partition() {
return null;
}
- /**
- * @param marsh Marshaller.
- */
- public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
- if (topic != null && topicBytes == null)
+ /** {@inheritDoc} */
+ @Override public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
+ if (topicOrd < 0 && topic != null && topicBytes == null)
topicBytes = U.marshal(marsh, topic);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr) throws IgniteCheckedException {
- if (topicBytes != null && topic == null) {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr) throws IgniteCheckedException {
+ if (topicOrd < 0 && topicBytes != null && topic == null) {
Review Comment:
```suggestion
if (topicOrd < 0 && topicBytes != null) {
```
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -219,31 +217,33 @@ public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
evtsBytes = U.marshal(marsh, evts);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- * @param filterClsLdr Class loader for filter.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr, ClassLoader filterClsLdr) throws IgniteCheckedException {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr) throws IgniteCheckedException {
if (resTopicBytes != null && resTopic == null) {
Review Comment:
```suggestion
if (resTopicBytes != null) {
```
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -205,10 +205,8 @@ public void loaderParticipants(@Nullable Map<UUID, IgniteUuid> ldrParties) {
return ErrorMessage.error(errMsg);
}
- /**
- * @param marsh Marshaller.
- */
- public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
+ /** {@inheritDoc} */
+ @Override public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
if (resTopic != null && resTopicBytes == null)
Review Comment:
```suggestion
if (resTopic != null)
```
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java:
##########
@@ -216,24 +218,21 @@ public int partition() {
return null;
}
- /**
- * @param marsh Marshaller.
- */
- public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
- if (topic != null && topicBytes == null)
+ /** {@inheritDoc} */
+ @Override public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
+ if (topicOrd < 0 && topic != null && topicBytes == null)
Review Comment:
```suggestion
if (topicOrd < 0 && topic != null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org