You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/10/06 00:51:19 UTC
[GitHub] [bookkeeper] pradeepbn opened a new pull request #2814: Building Bookkeeper with gradle on Java11
pradeepbn opened a new pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814
- Migrate bookkeepr-server:test to gradle run unit tests excepts org.apache.bookkeeper.bookie. org.apache.bookkeeper.client org.apache.bookkeeper.replication org.apache.bookkeeper.tls.
- Rest of the tests
- Exclude target directory from RAT plugin
- Not needed
Descriptions of the changes in this PR:
### Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
### Changes
(Describe: what changes you have made)
Master Issue: #<master-issue-number>
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on a change in pull request #2814: Building Bookkeeper with gradle on Java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on a change in pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814#discussion_r723736860
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
Yes, totally agree @mauricebarnum and made relevant changes in another PR #2817. I will close this PR since this is based on @pkumar-singh PR #2812 and want to keep it independent of #2812 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn closed pull request #2814: Building Bookkeeper with gradle on Java11
Posted by GitBox <gi...@apache.org>.
pradeepbn closed pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn closed pull request #2814: Building Bookkeeper with gradle on Java11
Posted by GitBox <gi...@apache.org>.
pradeepbn closed pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on a change in pull request #2814: Building Bookkeeper with gradle on Java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on a change in pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814#discussion_r723736860
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
Yes, totally agree and made relevant changes in another PR #2817. I will close this PR since this is based on @pkumar-singh PR #2812 and want to keep it independent of #2812 changes.
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
Yes, totally agree @mauricebarnum and made relevant changes in another PR #2817. I will close this PR since this is based on @pkumar-singh PR #2812 and want to keep it independent of #2812 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mauricebarnum commented on a change in pull request #2814: Building Bookkeeper with gradle on Java11
Posted by GitBox <gi...@apache.org>.
mauricebarnum commented on a change in pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814#discussion_r723542948
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
fwiw, gradle has first class support for JNI headers now. i didn't check the version, and i don't know gradle well enough yet to update the dependencies for the shared objects.
https://docs.gradle.org/current/dsl/org.gradle.api.tasks.compile.CompileOptions.html#org.gradle.api.tasks.compile.CompileOptions:headerOutputDirectory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pradeepbn commented on a change in pull request #2814: Building Bookkeeper with gradle on Java11
Posted by GitBox <gi...@apache.org>.
pradeepbn commented on a change in pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814#discussion_r723736860
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
Yes, totally agree and made relevant changes in another PR #2817. I will close this PR since this is based on @pkumar-singh PR #2812 and want to keep it independent of #2812 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org