[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3189:
URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r949565366


##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -312,6 +312,10 @@ message LogicalExprNode {
     CubeNode cube = 23;
 
     RollupNode rollup = 24;
+
+    // boolean operations
+    IsTrue is_true = 25;
+    IsFalse is_false = 26;

Review Comment:
   There is a mismatch between these names and the names used in the code. This change fixed the proto errors for me.
   
   ```suggestion
       IsTrue is_true_expr = 25;
       IsFalse is_false_expr = 26;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org