You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/29 09:42:28 UTC

[GitHub] [skywalking] yswdqz opened a new pull request, #9407: Add a new layer for MYSQL

yswdqz opened a new pull request, #9407:
URL: https://github.com/apache/skywalking/pull/9407

   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   Add a new layer for MYSQL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9407: Add a new layer for MYSQL

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9407:
URL: https://github.com/apache/skywalking/pull/9407#discussion_r933071199


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##########
@@ -116,7 +116,12 @@ public enum Layer {
     /**
      * Kubernetes service
      */
-    K8S_SERVICE(17, true);
+    K8S_SERVICE(17, true),
+
+    /**
+     * Telemetry from MYSQL

Review Comment:
   ```suggestion
        * mysqld, also known as MySQL Server, is a single multithreaded program that does most of the work in a MySQL installation. It does not spawn additional processes.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9407: Add a new layer for MYSQL

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9407:
URL: https://github.com/apache/skywalking/pull/9407#discussion_r933071199


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##########
@@ -116,7 +116,12 @@ public enum Layer {
     /**
      * Kubernetes service
      */
-    K8S_SERVICE(17, true);
+    K8S_SERVICE(17, true),
+
+    /**
+     * Telemetry from MYSQL

Review Comment:
   ```suggestion
        * MySQL Server, also known as mysqld, is a single multithreaded program that does most of the work in a MySQL installation. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng merged pull request #9407: Add a new layer for MYSQL

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9407:
URL: https://github.com/apache/skywalking/pull/9407


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org