You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/11/10 16:41:00 UTC

[jira] [Commented] (ARROW-8411) [C++] gcc6 warning re: arrow::internal::ArgSort

    [ https://issues.apache.org/jira/browse/ARROW-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441836#comment-17441836 ] 

Antoine Pitrou commented on ARROW-8411:
---------------------------------------

The diagnostic note makes the output a bit noisy but it is also entirely harmless, see [https://stackoverflow.com/questions/48149323/what-does-the-gcc-warning-project-parameter-passing-for-x-changed-in-gcc-7-1-m]

AFAIU it only manifests on ARM targets. We may want to disable the warning, but we may also not bother. cc [~yibocai] 

> [C++] gcc6 warning re: arrow::internal::ArgSort
> -----------------------------------------------
>
>                 Key: ARROW-8411
>                 URL: https://issues.apache.org/jira/browse/ARROW-8411
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Trivial
>
> Observed on a Debian platform with gcc6 base
> {code}
> In file included from /usr/include/c++/6/algorithm:62:0,
>                  from ../src/arrow/util/bit_util.h:55,
>                  from ../src/arrow/type_traits.h:26,
>                  from ../src/arrow/array.h:32,
>                  from ../src/arrow/compute/kernel.h:24,
>                  from ../src/arrow/dataset/filter.h:27,
>                  from ../src/arrow/dataset/partition.h:27,
>                  from /home/rock/code/arrow/cpp/src/arrow/dataset/partition.cc:18:
> /usr/include/c++/6/bits/stl_algo.h: In function 'void std::__insertion_sort(_RandomAccessIterator, _RandomAccessIterator, _Compare) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >; _Compare = __gnu_cxx::__ops::_Iter_comp_iter<arrow::internal::ArgSort(const std::vector<T>&, Cmp&&) [with T = std::__cxx11::basic_string<int>; Cmp = std::less<std::__cxx11::basic_string<int> >]::<lambda(int64_t, int64_t)> >]':
> /usr/include/c++/6/bits/stl_algo.h:1837:5: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>      __insertion_sort(_RandomAccessIterator __first,
>      ^~~~~~~~~~~~~~~~
> /usr/include/c++/6/bits/stl_algo.h:1837:5: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
> In file included from /usr/include/c++/6/bits/stl_algo.h:61:0,
>                  from /usr/include/c++/6/algorithm:62,
>                  from ../src/arrow/util/bit_util.h:55,
>                  from ../src/arrow/type_traits.h:26,
>                  from ../src/arrow/array.h:32,
>                  from ../src/arrow/compute/kernel.h:24,
>                  from ../src/arrow/dataset/filter.h:27,
>                  from ../src/arrow/dataset/partition.h:27,
>                  from /home/rock/code/arrow/cpp/src/arrow/dataset/partition.cc:18:
> /usr/include/c++/6/bits/stl_heap.h: In function 'void std::__adjust_heap(_RandomAccessIterator, _Distance, _Distance, _Tp, _Compare) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >; _Distance = int; _Tp = long long int; _Compare = __gnu_cxx::__ops::_Iter_comp_iter<arrow::internal::ArgSort(const std::vector<T>&, Cmp&&) [with T = std::__cxx11::basic_string<int>; Cmp = std::less<std::__cxx11::basic_string<int> >]::<lambda(int64_t, int64_t)> >]':
> /usr/include/c++/6/bits/stl_heap.h:209:5: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>      __adjust_heap(_RandomAccessIterator __first, _Distance __holeIndex,
>      ^~~~~~~~~~~~~
> In file included from /usr/include/c++/6/algorithm:62:0,
>                  from ../src/arrow/util/bit_util.h:55,
>                  from ../src/arrow/type_traits.h:26,
>                  from ../src/arrow/array.h:32,
>                  from ../src/arrow/compute/kernel.h:24,
>                  from ../src/arrow/dataset/filter.h:27,
>                  from ../src/arrow/dataset/partition.h:27,
>                  from /home/rock/code/arrow/cpp/src/arrow/dataset/partition.cc:18:
> /usr/include/c++/6/bits/stl_algo.h: In function 'void std::__introsort_loop(_RandomAccessIterator, _RandomAccessIterator, _Size, _Compare) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >; _Size = int; _Compare = __gnu_cxx::__ops::_Iter_comp_iter<arrow::internal::ArgSort(const std::vector<T>&, Cmp&&) [with T = std::__cxx11::basic_string<int>; Cmp = std::less<std::__cxx11::basic_string<int> >]::<lambda(int64_t, int64_t)> >]':
> /usr/include/c++/6/bits/stl_algo.h:1937:5: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>      __introsort_loop(_RandomAccessIterator __first,
>      ^~~~~~~~~~~~~~~~
> /usr/include/c++/6/bits/stl_algo.h:1937:5: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
> /usr/include/c++/6/bits/stl_algo.h:1951:4: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>     std::__introsort_loop(__cut, __last, __depth_limit, __comp);
>     ^~~
> /usr/include/c++/6/bits/stl_algo.h: In function 'std::vector<long long int> arrow::internal::ArgSort(const std::vector<T>&, Cmp&&) [with T = std::__cxx11::basic_string<int>; Cmp = std::less<std::__cxx11::basic_string<int> >]':
> /usr/include/c++/6/bits/stl_algo.h:1882:4: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>     std::__insertion_sort(__first, __first + int(_S_threshold), __comp);
>     ^~~
> /usr/include/c++/6/bits/stl_algo.h:1887:2: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>   std::__insertion_sort(__first, __last, __comp);
>   ^~~
> /usr/include/c++/6/bits/stl_algo.h:1965:4: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<long long int*, std::vector<long long int> >' will change in GCC 7.1
>     std::__introsort_loop(__first, __last,
>     ^~~
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)