You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/30 14:14:53 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.

wu-sheng commented on a change in pull request #4151: [test/plugin] immigrate test activemq scenario.
URL: https://github.com/apache/skywalking/pull/4151#discussion_r361996266
 
 

 ##########
 File path: test/plugin/scenarios/activemq-scenario/config/expectedData.yaml
 ##########
 @@ -25,24 +25,8 @@ segmentItems:
 - applicationCode: activemq-scenario
   segmentSize: ge 2
   segments:
-  - segmentId: /activemq-scenario/case/activemq
+  - segmentId: not null
     spans:
-      - operationName: ActiveMQ/Queue/test/Producer
 
 Review comment:
   Why remove this? We should have this in the expected data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services