[GitHub] [arrow-datafusion] alamb commented on a change in pull request #328: fix 305 by using a null array as param for zero param functions

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #328:
URL: https://github.com/apache/arrow-datafusion/pull/328#discussion_r630926134



##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -1373,20 +1393,24 @@ impl PhysicalExpr for ScalarFunctionExpr {
     }
 
     fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
-        // evaluate the arguments
-        let inputs = self
-            .args
-            .iter()
-            .map(|e| e.evaluate(batch))
-            .collect::<Result<Vec<_>>>()?;
+        // evaluate the arguments, if there are no arguments we'll instead pass in an uint32 holding

Review comment:
       this comment is now out of date as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org