[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35096: [SPARK-37806][K8S] Support minimum number of tasks per executor before being rolled

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35096:
URL: https://github.com/apache/spark/pull/35096#discussion_r778328300



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -168,6 +168,16 @@ private[spark] object Config extends Logging {
       .checkValues(ExecutorRollPolicy.values.map(_.toString))
       .createWithDefault(ExecutorRollPolicy.TOTAL_GC_TIME.toString)
 
+  val MINIMUM_TASKS_PER_EXECUTOR_BEFORE_ROLLING =
+    ConfigBuilder("spark.kubernetes.executor.minTasksPerExecutorBeforeRolling")
+      .doc("The minimum number of tasks per executor before rolling. " +
+        "Spark will not roll newly created executors whose total number of tasks is smaller" +

Review comment:
       Thank you for your review, @sunchao . I'll address them both.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org