You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/09 18:47:14 UTC

[GitHub] [airflow] jmcarp opened a new pull request #7669: [AIRFLOW-7019] Show un/pause errors in dags view.

jmcarp opened a new pull request #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669
 
 
   Pausing and unpausing dags in the dags view is asynchronous, and there
   is currently no indication to the user if the operation fails. This
   patch updates the paused input and highlights it in red when pausing or
   unpausing fails.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jmcarp commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.

Posted by GitBox <gi...@apache.org>.
jmcarp commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669#issuecomment-597139408
 
 
   Thanks @kaxil, I added a note to the FAQ.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jmcarp commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.

Posted by GitBox <gi...@apache.org>.
jmcarp commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669#issuecomment-598975831
 
 
   @kaxil should I go ahead and merge this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669#issuecomment-598976992
 
 
   Oh yes, please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jmcarp commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.

Posted by GitBox <gi...@apache.org>.
jmcarp commented on issue #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669#issuecomment-596717537
 
 
   Here's how the ui would look on a failed operation:
   
   ![Screen Shot 2020-03-09 at 2 46 45 PM](https://user-images.githubusercontent.com/1633460/76246949-1555c800-6215-11ea-82b3-d918e44f4513.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jmcarp merged pull request #7669: [AIRFLOW-7019] Show un/pause errors in dags view.

Posted by GitBox <gi...@apache.org>.
jmcarp merged pull request #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services