You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Miklos Erdelyi (JIRA)" <ji...@apache.org> on 2011/03/11 12:06:59 UTC
[jira] Created: (HAMA-365) TestBSPPeer doesn't check if the correct
number of messages have been received
TestBSPPeer doesn't check if the correct number of messages have been received
------------------------------------------------------------------------------
Key: HAMA-365
URL: https://issues.apache.org/jira/browse/HAMA-365
Project: Hama
Issue Type: Improvement
Components: test
Affects Versions: 0.2.0
Reporter: Miklos Erdelyi
Priority: Minor
TestBSPPeer only checks if messages received by the peer conform to a certain format but it does not check if there has been any messages received. I.e., it does not make sure that peer.getCurrentMessage() returns the required number of messages.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HAMA-365) TestBSPPeer doesn't check if the correct
number of messages have been received
Posted by "Miklos Erdelyi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Miklos Erdelyi updated HAMA-365:
--------------------------------
Attachment: test.num_messages.patch
This patch adds the required assertion.
> TestBSPPeer doesn't check if the correct number of messages have been received
> ------------------------------------------------------------------------------
>
> Key: HAMA-365
> URL: https://issues.apache.org/jira/browse/HAMA-365
> Project: Hama
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Miklos Erdelyi
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: test.num_messages.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> TestBSPPeer only checks if messages received by the peer conform to a certain format but it does not check if there has been any messages received. I.e., it does not make sure that peer.getCurrentMessage() returns the required number of messages.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HAMA-365) TestBSPPeer doesn't check if the correct
number of messages have been received
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-365:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've committed this. Thank Miklos.
> TestBSPPeer doesn't check if the correct number of messages have been received
> ------------------------------------------------------------------------------
>
> Key: HAMA-365
> URL: https://issues.apache.org/jira/browse/HAMA-365
> Project: Hama
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Miklos Erdelyi
> Assignee: Miklos Erdelyi
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: test.num_messages.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> TestBSPPeer only checks if messages received by the peer conform to a certain format but it does not check if there has been any messages received. I.e., it does not make sure that peer.getCurrentMessage() returns the required number of messages.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HAMA-365) TestBSPPeer doesn't check if the correct
number of messages have been received
Posted by "Miklos Erdelyi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Miklos Erdelyi updated HAMA-365:
--------------------------------
Fix Version/s: 0.2.0
Status: Patch Available (was: Open)
> TestBSPPeer doesn't check if the correct number of messages have been received
> ------------------------------------------------------------------------------
>
> Key: HAMA-365
> URL: https://issues.apache.org/jira/browse/HAMA-365
> Project: Hama
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Miklos Erdelyi
> Priority: Minor
> Fix For: 0.2.0
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> TestBSPPeer only checks if messages received by the peer conform to a certain format but it does not check if there has been any messages received. I.e., it does not make sure that peer.getCurrentMessage() returns the required number of messages.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HAMA-365) TestBSPPeer doesn't check if the
correct number of messages have been received
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-365:
-----------------------------------
Assignee: Miklos Erdelyi
Looks good to me.
But, please wait to fix HAMA-364
> TestBSPPeer doesn't check if the correct number of messages have been received
> ------------------------------------------------------------------------------
>
> Key: HAMA-365
> URL: https://issues.apache.org/jira/browse/HAMA-365
> Project: Hama
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Miklos Erdelyi
> Assignee: Miklos Erdelyi
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: test.num_messages.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> TestBSPPeer only checks if messages received by the peer conform to a certain format but it does not check if there has been any messages received. I.e., it does not make sure that peer.getCurrentMessage() returns the required number of messages.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HAMA-365) TestBSPPeer doesn't check if the
correct number of messages have been received
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005605#comment-13005605 ]
Hudson commented on HAMA-365:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12473380/test.num_messages.patch
against trunk revision 1079676.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/310/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/310/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/310/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/310/console
This message is automatically generated.
> TestBSPPeer doesn't check if the correct number of messages have been received
> ------------------------------------------------------------------------------
>
> Key: HAMA-365
> URL: https://issues.apache.org/jira/browse/HAMA-365
> Project: Hama
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Miklos Erdelyi
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: test.num_messages.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> TestBSPPeer only checks if messages received by the peer conform to a certain format but it does not check if there has been any messages received. I.e., it does not make sure that peer.getCurrentMessage() returns the required number of messages.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira