You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "spars57 (via GitHub)" <gi...@apache.org> on 2024/05/14 09:00:41 UTC

[I] HTTP Headers Configuration on config.py not overriding. [superset]

spars57 opened a new issue, #28491:
URL: https://github.com/apache/superset/issues/28491

   ### Bug description
   
   When trying to embed a dashboard I can't because "X-Frame-Options" is set to "SAMEORIGIN".
   
   I'm using Superset v3.10.
   
   I tried to override it on config.py file like this:
   
   OVERRIDE_HTTP_HEADERS: dict[str, Any] = {'X-Frame-Options': 'ALLOW-FROM http://localhost:5173'}
   
   I have added the same value to DEFAULT_HTTP_HEADERS and HTTP_HEADERS but nothing seems to work because looks like this variables are being ignored by the server.
   
   "X-Frame-Options" always keeps the same value..
   
   ### How to reproduce the bug
   
   Try to embed a dashboard on a different domain 
   
   ### Screenshots/recordings
   
   <img width="1175" alt="image" src="https://github.com/apache/superset/assets/79933117/5729ad04-1aa9-4d5f-8485-a80af292f9ae">
   
   
   ### Superset version
   
   3.1.3
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] HTTP Headers Configuration on config.py not overriding. [superset]

Posted by "spars57 (via GitHub)" <gi...@apache.org>.
spars57 commented on issue #28491:
URL: https://github.com/apache/superset/issues/28491#issuecomment-2110795382

   I found out the solution, I had to configure Talisman like this on config.py:
   TALISMAN_ENABLED = True
   TALISMAN_DEV_CONFIG = {
           ...
           "frame_options": 'ALLOWALL',
           'frame_options_allow_from': '*',
   }  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] HTTP Headers Configuration on config.py not overriding. [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #28491:
URL: https://github.com/apache/superset/issues/28491#issuecomment-2109659291

   <!-- Greeting -->
   Hey there, @spars57! 👋 I'm [Dosu](https://dosu.dev), your friendly neighborhood bot here to lend a hand with bugs, answer questions, and guide you towards becoming a contributor to the Superset community. While we're waiting for a human maintainer to swoop in, I'm here to assist you. I'm diving into your issue about HTTP headers configuration in Superset and will get back to you with some insights shortly. Stay tuned!
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] HTTP Headers Configuration on config.py not overriding. [superset]

Posted by "spars57 (via GitHub)" <gi...@apache.org>.
spars57 closed issue #28491: HTTP Headers Configuration on config.py not overriding.
URL: https://github.com/apache/superset/issues/28491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] HTTP Headers Configuration on config.py not overriding. [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28491:
URL: https://github.com/apache/superset/issues/28491#issuecomment-2110555749

   Curious why you closed it... did the bot help? We're still trying to figure out how useful it is :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org