[GitHub] [doris] morningman commented on a diff in pull request #20550: [feature](alter) Add AlterDatabasePropertyStmt binlog impl

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #20550:
URL: https://github.com/apache/doris/pull/20550#discussion_r1222565612


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java:
##########
@@ -121,6 +121,9 @@ public enum DbState {
     @SerializedName(value = "dbProperties")
     private DatabaseProperty dbProperties = new DatabaseProperty();
 
+    @SerializedName(value = "binlogConfig")
+    private BinlogConfig binlogConfig = new BinlogConfig();

Review Comment:
   Can it be put into `dbProperties`?



##########
fe/fe-core/src/main/java/org/apache/doris/persist/AlterDatabasePropertyInfo.java:
##########
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.persist;
+
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.persist.gson.GsonUtils;
+
+import com.google.gson.annotations.SerializedName;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.Map;
+
+public class AlterDatabasePropertyInfo implements Writable {
+    @SerializedName(value = "dbName")
+    private String dbName;

Review Comment:
   Better use database id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org