You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by lu...@free.fr on 2010/08/02 10:33:37 UTC
[math] splitting LocalizedFormats enum (was Re: svn commit: r981404
[1/3])
----- luc@apache.org a écrit :
> Author: luc
> Date: Mon Aug 2 08:10:39 2010
> New Revision: 981404
>
> URL: http://svn.apache.org/viewvc?rev=981404&view=rev
> Log:
> Moved the localization framework used for exceptions in the exceptions package.
> Its former place (in the utils package) was misleading as utils is rather for
> numerical utilities, not low level library management
This big patch (sorry for the noise) is simple moving three classes from one package to another one.
In order to simplify messages handling, perhaps we should split the LocalizedFormats enum that contains all messages in seperate enums. Unfortunately, it seems impossible to have several enums extending an abstract class, so the implementation of the getLocalizedString method must be duplicated (changinf the resources bundle name, of course), it cannot be shared.
Gilles, what about using a specific enum for the new runtime exceptions messages ?
Luc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] splitting LocalizedFormats enum (was Re: svn commit:
r981404 [1/3])
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
> > Author: luc
> > Date: Mon Aug 2 08:10:39 2010
> > New Revision: 981404
> >
> > URL: http://svn.apache.org/viewvc?rev=981404&view=rev
> > Log:
> > Moved the localization framework used for exceptions in the exceptions package.
> > Its former place (in the utils package) was misleading as utils is rather for
> > numerical utilities, not low level library management
>
> This big patch (sorry for the noise) is simple moving three classes from one package to another one.
>
> In order to simplify messages handling, perhaps we should split the LocalizedFormats enum that contains all messages in seperate enums. Unfortunately, it seems impossible to have several enums extending an abstract class, so the implementation of the getLocalizedString method must be duplicated (changinf the resources bundle name, of course), it cannot be shared.
>
> Gilles, what about using a specific enum for the new runtime exceptions messages ?
Right now, I see no problem with that; but I didn't understand what you
are aiming at (what simplification will be achieved).
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org