You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by keypointt <gi...@git.apache.org> on 2016/07/07 23:15:27 UTC
[GitHub] spark pull request #14097: [MINOR][Streaming][Docs] Minor changes on kinesis...
GitHub user keypointt opened a pull request:
https://github.com/apache/spark/pull/14097
[MINOR][Streaming][Docs] Minor changes on kinesis integration
## What changes were proposed in this pull request?
Some minor changes for documentation page "Spark Streaming + Kinesis Integration".
Moved "streaming-kinesis-arch.png" before the bullet list, not in between the bullets.
## How was this patch tested?
Tested manually, on my local machine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keypointt/spark kinesisDoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14097
----
commit 7d5e6982b247a5f40fc36037322716bdcb4b9bda
Author: Xin Ren <ia...@126.com>
Date: 2016-07-07T23:05:43Z
minor changes on kinesis integration
commit 0740b2b053d854f394aa2094a29dd878e4d4bd5d
Author: Xin Ren <ia...@126.com>
Date: 2016-07-07T23:11:43Z
fix url to aws doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14097: [MINOR][Streaming][Docs] Minor changes on kinesis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14097
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14097
**[Test build #61937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61937/consoleFull)** for PR 14097 at commit [`0740b2b`](https://github.com/apache/spark/commit/0740b2b053d854f394aa2094a29dd878e4d4bd5d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14097
**[Test build #62061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62061/consoleFull)** for PR 14097 at commit [`55dc2a2`](https://github.com/apache/spark/commit/55dc2a2d420e30d211117a3d9fd964dcb3b45604).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14097
**[Test build #61937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61937/consoleFull)** for PR 14097 at commit [`0740b2b`](https://github.com/apache/spark/commit/0740b2b053d854f394aa2094a29dd878e4d4bd5d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on the issue:
https://github.com/apache/spark/pull/14097
maybe I should also cc @tdas , he is on the streaming part
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14097
**[Test build #62061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62061/consoleFull)** for PR 14097 at commit [`55dc2a2`](https://github.com/apache/spark/commit/55dc2a2d420e30d211117a3d9fd964dcb3b45604).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14097
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14097: [MINOR][Streaming][Docs] Minor changes on kinesis...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14097#discussion_r70186026
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -9,7 +9,7 @@ Here we explain how to configure Spark Streaming to receive data from Kinesis.
#### Configuring Kinesis
-A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards per the following
+A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards following
--- End diff --
Yes, but that's only removing "following" and I don't think that's an improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14097
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on the issue:
https://github.com/apache/spark/pull/14097
hi @srowen do you mind have a look at this one? very minor changes...
thank you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14097: [MINOR][Streaming][Docs] Minor changes on kinesis...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14097#discussion_r70186200
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -9,7 +9,7 @@ Here we explain how to configure Spark Streaming to receive data from Kinesis.
#### Configuring Kinesis
-A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards per the following
+A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards following
--- End diff --
I see... I'll revert it back to original
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14097
Seems reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14097: [MINOR][Streaming][Docs] Minor changes on kinesis...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14097#discussion_r70180299
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -9,7 +9,7 @@ Here we explain how to configure Spark Streaming to receive data from Kinesis.
#### Configuring Kinesis
-A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards per the following
+A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards following
--- End diff --
The sentence was correct before but now is ungrammatical
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/14097
LGTM. Merging to master and 2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14097: [MINOR][Streaming][Docs] Minor changes on kinesis...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14097#discussion_r70185756
--- Diff: docs/streaming-kinesis-integration.md ---
@@ -9,7 +9,7 @@ Here we explain how to configure Spark Streaming to receive data from Kinesis.
#### Configuring Kinesis
-A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards per the following
+A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or more shards following
--- End diff --
excuse me for my English...
kinesis stream can be set (...) per the guide?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14097
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61937/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14097: [MINOR][Streaming][Docs] Minor changes on kinesis integr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14097
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62061/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org