You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/07 22:56:45 UTC
Review Request 66992: Made the master drop operations with an ID on
non-default resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66992/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Made the master drop operations with an ID on non-default resources.
Diffs
-----
src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2
src/tests/master_tests.cpp e159573b550b07f5315878a6eabb3b84080bf15a
src/tests/operation_reconciliation_tests.cpp 9717e8454a7d4654c58b903a8420aee2b0cea8a2
Diff: https://reviews.apache.org/r/66992/diff/1/
Testing
-------
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 66992: Made the master drop operations with an ID
on non-default resources.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66992/
-----------------------------------------------------------
(Updated May 7, 2018, 5:04 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed feedback.
Repository: mesos
Description
-------
Made the master drop operations with an ID on non-default resources.
Diffs (updated)
-----
src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2
src/tests/master_tests.cpp e159573b550b07f5315878a6eabb3b84080bf15a
src/tests/operation_reconciliation_tests.cpp 9717e8454a7d4654c58b903a8420aee2b0cea8a2
Diff: https://reviews.apache.org/r/66992/diff/2/
Changes: https://reviews.apache.org/r/66992/diff/1-2/
Testing
-------
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 66992: Made the master drop operations with an ID
on non-default resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66992/#review202605
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_tests.cpp
Lines 9024 (patched)
<https://reviews.apache.org/r/66992/#comment284491>
s/DROPPED/ERROR/
- Greg Mann
On May 7, 2018, 10:56 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66992/
> -----------------------------------------------------------
>
> (Updated May 7, 2018, 10:56 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the master drop operations with an ID on non-default resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2
> src/tests/master_tests.cpp e159573b550b07f5315878a6eabb3b84080bf15a
> src/tests/operation_reconciliation_tests.cpp 9717e8454a7d4654c58b903a8420aee2b0cea8a2
>
>
> Diff: https://reviews.apache.org/r/66992/diff/1/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>