You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/02/20 06:02:41 UTC
Review Request 18301: Failure tolerance parameter doesn't seem to work for
Rolling Restarts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18301/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar, Myroslav Papirkovskyy, and Sumit Mohanty.
Bugs: AMBARI-4758
https://issues.apache.org/jira/browse/AMBARI-4758
Repository: ambari
Description
-------
Trigger rolling restart with failure tolerance set to 1.
Induce a fail of restart operation somehow on the component, being restarted.
Result: batches are scheduled after the first operation fails.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java d4602a2
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java ef8dc9d
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestJob.java 0718dcc
ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java 7ed183f
Diff: https://reviews.apache.org/r/18301/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 18301: Failure tolerance parameter doesn't seem to work
for Rolling Restarts
Posted by Sid Wagle <sw...@hortonworks.com>.
> On Feb. 20, 2014, 5:21 a.m., Sumit Mohanty wrote:
> > Minor comments:
> >
> > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
> > Do we need the "import org.quartz.JobDataMap;"?
> >
> > Why does addTaskCountToProperties() need explicit throws ?
> >
Incorporated comments.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18301/#review34984
-----------------------------------------------------------
On Feb. 20, 2014, 5:02 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18301/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 5:02 a.m.)
>
>
> Review request for Ambari, Mahadev Konar, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-4758
> https://issues.apache.org/jira/browse/AMBARI-4758
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Trigger rolling restart with failure tolerance set to 1.
> Induce a fail of restart operation somehow on the component, being restarted.
>
> Result: batches are scheduled after the first operation fails.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java d4602a2
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java ef8dc9d
> ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestJob.java 0718dcc
> ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java 7ed183f
>
> Diff: https://reviews.apache.org/r/18301/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 18301: Failure tolerance parameter doesn't seem to work
for Rolling Restarts
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18301/#review34984
-----------------------------------------------------------
Ship it!
Minor comments:
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
Do we need the "import org.quartz.JobDataMap;"?
Why does addTaskCountToProperties() need explicit throws ?
- Sumit Mohanty
On Feb. 20, 2014, 5:02 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18301/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 5:02 a.m.)
>
>
> Review request for Ambari, Mahadev Konar, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-4758
> https://issues.apache.org/jira/browse/AMBARI-4758
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Trigger rolling restart with failure tolerance set to 1.
> Induce a fail of restart operation somehow on the component, being restarted.
>
> Result: batches are scheduled after the first operation fails.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java d4602a2
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java ef8dc9d
> ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestJob.java 0718dcc
> ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java 7ed183f
>
> Diff: https://reviews.apache.org/r/18301/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>