You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/13 01:15:24 UTC
[GitHub] [pulsar-client-go] labuladong opened a new pull request, #910: [improve][ci] change token name to `GITHUB_TOKEN`
labuladong opened a new pull request, #910:
URL: https://github.com/apache/pulsar-client-go/pull/910
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #909
### Modifications
Change token to `GITHUB_TOKEN`.
After changing, the pulsar bot works fine. Example here:
https://github.com/labuladong/pulsar-client-go/actions/runs/3681253024/jobs/6227745474#step:4:27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun commented on pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910#issuecomment-1347614118
A possible issue is that this default token may not have the write permission required and thus fail to write comment/update status on demand. You can check it (it may work differently from you personal fork and in the upstream) or we just give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] labuladong commented on pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910#issuecomment-1347629026
Some information about `GITHUB_TOKEN`:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun commented on pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910#issuecomment-1508226156
```
rerun-failed-jobs for 'CI'. Follow progress at https://github.com/apache/pulsar-client-go/actions/runs/2812684476
{
"message": "Unable to retry this workflow run because it was created over a month ago",
"documentation_url": "https://docs.github.com/rest/reference/actions#re-run-workflow-failed-jobs"
}
Failed.
```
https://github.com/apache/pulsar-client-go/actions/runs/4698390864/jobs/8330614311
It seems default token doesn't have enough permission to trigger rerun. Although we can file an INFRA ticket to add one, but IIRC INFRA will reject configure personal access token as we do before - we may be an actual bot account.
I'm OK to leave it as is or delete the workflow file since we can actually live well without this functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] labuladong commented on pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910#issuecomment-1347618624
> A possible issue is that this default token may not have the write permission required.
I found the bot in the pulsar repo also uses another token:
So maybe you are right. I guess the default token doesn't have permission to restart the CI task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun commented on pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910#issuecomment-1508207104
This change doesn't make the case worse. Let's give it a try.
If it still won't work, we can find other approach or just remove the workflow since we actually live well without this functionality always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] tisonkun merged pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] labuladong commented on pull request #910: [improve][ci] change token name to `GITHUB_TOKEN`
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #910:
URL: https://github.com/apache/pulsar-client-go/pull/910#issuecomment-1347625385
Yes, the behavior in the upstream repo may be different from my fork. So this pr may not work. Do you have any ideas to fix the bug about the CI bot? @tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org