You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/10/15 18:34:40 UTC

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11686


Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................

KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

This patch breaks out the test harness and test
util classes into a seperate module.  As a side change it
also breaks out the protobuf compilation/classes.

This cleans up the dependencies on test jars and
is a preliminary step to a public test utility. Though
all of the classes still remain marked as private
until the interfaces are fleshed out further.

Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
---
M java/kudu-backup/build.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/SecureKuduSinkTest.java
M java/kudu-hive/build.gradle
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
A java/kudu-protocol/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
A java/kudu-test-utils/build.gradle
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
M java/settings.gradle
71 files changed, 253 insertions(+), 193 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11686/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle
File java/kudu-protocol/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18
PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle"
> What's the purpose of this new module?
Breaking out the protocol build is a bit of a side task now. It was
needed at one point, but isn't required anymore. I kept it broke 
out because I liked the protobuf compiled classes being in a 
separate module/jar from the client code. It could be useful for
protocol testing, or other implementations to use the protocol
directly.


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@35
PS2, Line 35: protcol
> protocol
Done


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@22
PS2, Line 22:   
> whitespace
Done


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@34
PS2, Line 34: // kudu-test-utils has no public Javadoc.
> Seems like it should?
Because all of the classes are marked as InterfaceAudiance.Private the javadoc doclet filters them out of the docs. Once we make some things public we can remove this.


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java@179
PS2, Line 179:       throw new IOException(resp.getError().getMessage());
> This should probably be RuntimeException, this is an error happening on the
NonRecoverableException is package private. I could change that, but given that the end result is essentially an IOException that contains the response message I figured this was fine.



-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Oct 2018 14:35:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11686

to look at the new patch set (#3).

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................

KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

This patch breaks out the test harness and test
util classes into a seperate module.  As a side change it
also breaks out the protobuf compilation/classes.

This cleans up the dependencies on test jars and
is a preliminary step to a public test utility. Though
all of the classes still remain marked as private
until the interfaces are fleshed out further.

Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
---
M java/kudu-backup/build.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/SecureKuduSinkTest.java
M java/kudu-hive/build.gradle
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
A java/kudu-protocol/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
A java/kudu-test-utils/build.gradle
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
R java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/settings.gradle
71 files changed, 259 insertions(+), 194 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11686/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 20:40:39 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................

KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

This patch breaks out the test harness and test
util classes into a seperate module.

This cleans up the dependencies on test jars and
is a preliminary step to a public test utility. Though
all of the classes still remain marked as private
until the interfaces are fleshed out further.

Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Reviewed-on: http://gerrit.cloudera.org:8080/11686
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/build.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/SecureKuduSinkTest.java
M java/kudu-hive/build.gradle
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
A java/kudu-test-utils/build.gradle
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
R java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/settings.gradle
70 files changed, 218 insertions(+), 182 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Adar Dembo: Looks good to me, but someone else must approve
  Grant Henke: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11686

to look at the new patch set (#2).

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................

KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

This patch breaks out the test harness and test
util classes into a seperate module.  As a side change it
also breaks out the protobuf compilation/classes.

This cleans up the dependencies on test jars and
is a preliminary step to a public test utility. Though
all of the classes still remain marked as private
until the interfaces are fleshed out further.

Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
---
M java/kudu-backup/build.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/SecureKuduSinkTest.java
M java/kudu-hive/build.gradle
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
A java/kudu-protocol/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
A java/kudu-test-utils/build.gradle
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
R java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/settings.gradle
71 files changed, 258 insertions(+), 194 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11686/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle
File java/kudu-protocol/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18
PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle"
> Breaking out the protocol build is a bit of a side task now. It was
Does it result in an additional JAR that needs to be published and transitively depended on by the other modules?


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26
PS2, Line 26: 
> CapturingLogAppender depends on some log4j specific things. I will see what
ah OK, I wouldn't worry about it then



-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 00:32:38 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 04:08:22 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 19:31:51 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11686

to look at the new patch set (#5).

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................

KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

This patch breaks out the test harness and test
util classes into a seperate module.

This cleans up the dependencies on test jars and
is a preliminary step to a public test utility. Though
all of the classes still remain marked as private
until the interfaces are fleshed out further.

Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
---
M java/kudu-backup/build.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/SecureKuduSinkTest.java
M java/kudu-hive/build.gradle
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
A java/kudu-test-utils/build.gradle
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
R java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/settings.gradle
70 files changed, 218 insertions(+), 182 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11686/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle
File java/kudu-protocol/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18
PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle"
What's the purpose of this new module?


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@35
PS2, Line 35: protcol
protocol


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@22
PS2, Line 22:   
whitespace


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26
PS2, Line 26:   compileUnshaded libs.log4j
Shouldn't this and slf4jLog4j12 be test scoped dependencies?  I imagine people are going to use this module as a library, right?


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@34
PS2, Line 34: // kudu-test-utils has no public Javadoc.
Seems like it should?


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java@179
PS2, Line 179:       throw new IOException(resp.getError().getMessage());
This should probably be RuntimeException, this is an error happening on the server side which has been successfully transmitted back.  Are Status.fromPB and NonREcoverableException ctor's private?



-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 15 Oct 2018 21:42:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26
PS2, Line 26:   compileUnshaded libs.log4j
> Shouldn't this and slf4jLog4j12 be test scoped dependencies?  I imagine peo
CapturingLogAppender depends on some log4j specific things. I will see what I can do to remove these.



-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Oct 2018 14:38:37 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle
File java/kudu-protocol/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18
PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle"
> Does it result in an additional JAR that needs to be published and transiti
It is another jar published but it is shaded by the client and doesn't have any transitive impact.


http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26
PS2, Line 26:   compileUnshaded libs.log4j
> CapturingLogAppender depends on some log4j specific things. I will see what
I marked these dependencies as optional so they won't be pulled in by default, but need to exist if CapturingLogAppender is used.



-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 02:24:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 17 Oct 2018 19:20:06 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11686

to look at the new patch set (#4).

Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module
......................................................................

KUDU-2411: (Part 1) Break out existing test utilities into a seperate module

This patch breaks out the test harness and test
util classes into a seperate module.  As a side change it
also breaks out the protobuf compilation/classes.

This cleans up the dependencies on test jars and
is a preliminary step to a public test utility. Though
all of the classes still remain marked as private
until the interfaces are fleshed out further.

Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
---
M java/kudu-backup/build.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerTest.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/SecureKuduSinkTest.java
M java/kudu-hive/build.gradle
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
A java/kudu-protocol/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
A java/kudu-test-utils/build.gradle
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
R java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
R java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/settings.gradle
71 files changed, 259 insertions(+), 194 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11686/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins