You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by simonsouth <gi...@git.apache.org> on 2015/07/30 18:44:13 UTC
[GitHub] thrift pull request: THRIFT-3260 multiple warnings in c glib tutor...
GitHub user simonsouth opened a pull request:
https://github.com/apache/thrift/pull/572
THRIFT-3260 multiple warnings in c glib tutorial
This patch resolves the remaining warning messages output by the compiler when building the C (GLib) tutorial. It
- Modifies the compiler to not emit spurious semicolons after GObject type macros (e.g G_DEFINE_TYPE),
- Removes a spurious semicolon at an equivalent spot in the server tutorial,
- Modifies the compiler to explicitly state initializer and class-initializer parameters are unused if they are and
- Disables the warning about unused functions when building (only) the generated code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonsouth/thrift thrift-3260-multiple-warnings-in-c_glib-tutorial
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #572
----
commit 5359a2432c0b67b8756e1cd964054ee3f4adb46f
Author: Simon South <ss...@simonsouth.com>
Date: 2015-07-28T10:48:55Z
c_glib: Compiler: Omit spurious ";" after GObject type macros
commit 99b60a1aaf9356fbd1e02f63fb7c3c1e9a0061b0
Author: Simon South <ss...@simonsouth.com>
Date: 2015-07-28T10:57:37Z
c_glib: Compiler: Suppress unused-var warnings in client initializers
commit 344998fbdcdb3bf23a593a5983a4658d7a29d921
Author: Simon South <ss...@simonsouth.com>
Date: 2015-07-28T11:53:33Z
c_glib: Tutorial: Remove spurious ";" from GObject type macro
commit c40ac038e349167fc870af5d3de4ed471d0cf037
Author: Simon South <ss...@simonsouth.com>
Date: 2015-07-28T15:06:39Z
c_glib: Tutorial: Silence unused-function warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3260 multiple warnings in c glib tutor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---