[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3221: [NETBEANS-6081] - Cleaning enterprise module part 1/8:

[GitBox <gi...@apache.org>]

neilcsmith-net edited a comment on pull request #3221:
URL: https://github.com/apache/netbeans/pull/3221#issuecomment-940228357


   > so you are saying it isn't feature freeze yet? ;)
   
   And we've always had a thing that said favour merging early rather than later. Being aware of the release cycle is quite normal. Just saying this may or may not get to 8 of 8 by freeze!
   
   Yes, I understand the point of not letting things stagnate too.  Good timing is important in both aspects.
   
   EDIT : incidentally, one reason I reviewed the changes was concern over the use of the words "sweeping changes", which probably made this sound a bit more major than it is.
   
   > if the destination type is a primitive and the source is a String, then yes. Should be easy to formulate a jackpot rule if there isn't one yet. If the destination is an Object, then valueOf is ok.
   
   Yes, there's a quite a few that are setting or returning primitives, eg. `LogHyperLinkSupport`, `LogViewer`, `ServerLog`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists