You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mjsax <gi...@git.apache.org> on 2016/01/07 15:48:21 UTC
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1493
[FLINK-3189] Error while parsing job arguments passed by CLI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-3189-cli-info
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1493
----
commit 9b4d8f1251ce485421397244f20c182a135428c3
Author: mjsax <mj...@apache.org>
Date: 2016-01-07T13:20:59Z
[FLINK-3189] Error while parsing job arguments passed by CLI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1493#issuecomment-171055292
Will change the option to `-f` and merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1493#issuecomment-170362531
Done. Failing Travis is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1493#issuecomment-170032469
Can you add a test case that guards this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1493#issuecomment-170035218
Sure. Will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3189] Error while parsing job arguments...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1493#discussion_r49507511
--- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendInfoTest.java ---
@@ -61,7 +61,7 @@ public void testShowExecutionPlan() {
replaceStdOut();
try {
- String[] parameters = new String[] { CliFrontendTestUtils.getTestJarPath() };
+ String[] parameters = new String[] { CliFrontendTestUtils.getTestJarPath(), "-v", "true", "/dev/null", "/dev/null"};
--- End diff --
`-v` is a valid option. I would change it to `-f` which is also the option initially causing the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---