You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devmadhuu (via GitHub)" <gi...@apache.org> on 2026/07/20 06:48:39 UTC
[PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
devmadhuu opened a new pull request, #10815:
URL: https://github.com/apache/ozone/pull/10815
## What changes were proposed in this pull request?
Thread a `StorageTier` from the SCM block-allocation RPC down to `PipelineFactory.create`, so callers can request a pipeline (and, via #10810 , a container) on a specific storage tier. Removes the `// TODO StoragePolicy replace this StorageTier with the passed StorageTier` hardcode in `PipelineFactory` that forced every pipeline creation onto DISK.
Please describe your PR in detail:
1. Thread StorageTier through the block-allocation RPC and BlockManager
2. Wire StorageTier into PipelineManager and PipelineFactory
Depends on #10810 (which adds a persisted `StorageTier` field to `ContainerInfo`)
Now with this PR:
- OM can now send a tier on `AllocateScmBlock`.
- SCM builds a pipeline on that tier (via `RatisPipelineProvider`/`ECPipelineProvider`, already tier-capable from HDDS-15250).
- The allocated container inherits the tier from its pipeline (via #10810) and survives SCM restart.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15249
## How was this patch tested?
Updated and extended tests in `TestBlockManager`, `TestSCMBlockProtocolServer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on PR #10815:
URL: https://github.com/apache/ozone/pull/10815#issuecomment-5061462347
overall LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #10815:
URL: https://github.com/apache/ozone/pull/10815#issuecomment-5036978166
@xichen01 Kindly review as discussed [here](https://github.com/apache/ozone/pull/10810#issuecomment-5036834985)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on PR #10815:
URL: https://github.com/apache/ozone/pull/10815#issuecomment-5048537384
@amaliujia @greenwich @chungen0126 @ivandika3 @peterxcli Please help to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu merged PR #10815:
URL: https://github.com/apache/ozone/pull/10815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on code in PR #10815:
URL: https://github.com/apache/ozone/pull/10815#discussion_r3624492995
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java:
##########
Review Comment:
We should pass the `storageTier` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #10815:
URL: https://github.com/apache/ozone/pull/10815#discussion_r3629931304
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java:
##########
Review Comment:
Done. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15249. SCM Pipeline Support Create And Get With StorageTier [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #10815:
URL: https://github.com/apache/ozone/pull/10815#issuecomment-5087664308
> overall LGTM +1
Thanks @xichen01 for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org