You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2017/02/15 20:54:44 UTC
Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/
-----------------------------------------------------------
Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
Repository: geode
Description
-------
Reduced logging level of specific exceptions from warn level to debug
I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
Diff: https://reviews.apache.org/r/56719/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
Posted by Jason Huynh <jh...@pivotal.io>.
> On Feb. 15, 2017, 9:33 p.m., nabarun nag wrote:
> > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java, line 58
> > <https://reviews.apache.org/r/56719/diff/1/?file=1634867#file1634867line58>
> >
> > Hi Jason,
> >
> > I am not sure but should we have an identical catch block for afterPrimary too??
This one I am not sure about. I think we could but it might be helpful to know why we didn't create a bucket when we turned to primary.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/#review165761
-----------------------------------------------------------
On Feb. 15, 2017, 8:54 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56719/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:54 p.m.)
>
>
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Reduced logging level of specific exceptions from warn level to debug
>
> I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
>
> No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
>
> Diff: https://reviews.apache.org/r/56719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/#review165761
-----------------------------------------------------------
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java (line 58)
<https://reviews.apache.org/r/56719/#comment237623>
Hi Jason,
I am not sure but should we have an identical catch block for afterPrimary too??
- nabarun nag
On Feb. 15, 2017, 8:54 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56719/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:54 p.m.)
>
>
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Reduced logging level of specific exceptions from warn level to debug
>
> I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
>
> No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
>
> Diff: https://reviews.apache.org/r/56719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/#review165772
-----------------------------------------------------------
Ship it!
Ship It!
- xiaojian zhou
On Feb. 15, 2017, 8:54 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56719/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:54 p.m.)
>
>
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Reduced logging level of specific exceptions from warn level to debug
>
> I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
>
> No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
>
> Diff: https://reviews.apache.org/r/56719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/#review165766
-----------------------------------------------------------
Ship it!
Ship It!
- nabarun nag
On Feb. 15, 2017, 8:54 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56719/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:54 p.m.)
>
>
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Reduced logging level of specific exceptions from warn level to debug
>
> I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
>
> No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
>
> Diff: https://reviews.apache.org/r/56719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 12:02 a.m.)
Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
Changes
-------
modified exception handling when executing the LuceneFunction. It will now log as debug level.
Also catching PrimaryBucketException and logging afterPrimary exceptions as info instead of warning.
Repository: geode
Description
-------
Reduced logging level of specific exceptions from warn level to debug
I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
Diffs (updated)
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java 9d45526
Diff: https://reviews.apache.org/r/56719/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 56719: GEODE-2491: Reduce logging of handled
exceptions in LuceneEventListener and LuceneBucketListeners
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/#review165774
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Feb. 15, 2017, 8:54 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56719/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:54 p.m.)
>
>
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Reduced logging level of specific exceptions from warn level to debug
>
> I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something different for each type or not...
>
> No longer catching all exceptions when closing the lucene index, instead only handling specific ones, we can add more if we see others being thrown...
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java 0af2719
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java 44453e4
>
> Diff: https://reviews.apache.org/r/56719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>