You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/24 06:40:32 UTC
[GitHub] [flink] fsk119 opened a new pull request, #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
fsk119 opened a new pull request, #20063:
URL: https://github.com/apache/flink/pull/20063
…sultInParallel
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Fix the unstable test case. The root cause is the fetcher thread and another thread is in parallel. There are two cases:*
*1. The fetcher gets the Operation and then another thread closes the Operation. Then the fetcher gets the error message "Can not fetch results in closed operation."*
*2. The closing thread closes the Operation and removes the Operation from the Operation Manager, then the fetcher tries to fetch the results. In this case, the fetcher will get the message "Can not find the operation".*
## Brief change log
- *Matches the expected error message in the test.*
- *In the concurrent test, the thread print the error msg to the terminal when getting exceptions. Introduce an `IgnoreErrorThreadFactory` to swallow the useless message.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lsyldliu commented on a diff in pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
lsyldliu commented on code in PR #20063:
URL: https://github.com/apache/flink/pull/20063#discussion_r909228723
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/utils/IgnoreErrorThreadFactory.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.gateway.service.utils;
+
+import org.jetbrains.annotations.NotNull;
+
+import java.util.concurrent.ThreadFactory;
+
+/** Factory to create the thread that ignores error message. */
+public class IgnoreErrorThreadFactory implements ThreadFactory {
+
+ public static final IgnoreErrorThreadFactory INSTANCE = new IgnoreErrorThreadFactory();
+
+ private IgnoreErrorThreadFactory() {}
+
+ @Override
+ public Thread newThread(@NotNull Runnable r) {
+ Thread thread = new Thread(r);
+ thread.setUncaughtExceptionHandler(
+ new Thread.UncaughtExceptionHandler() {
+ @Override
+ public void uncaughtException(Thread t, Throwable e) {
+ // ignore error
Review Comment:
Would better if here log the exception message, please refer the `FatalExitExceptionHandler`
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/utils/IgnoreErrorThreadFactory.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.gateway.service.utils;
+
+import org.jetbrains.annotations.NotNull;
+
+import java.util.concurrent.ThreadFactory;
+
+/** Factory to create the thread that ignores error message. */
+public class IgnoreErrorThreadFactory implements ThreadFactory {
+
+ public static final IgnoreErrorThreadFactory INSTANCE = new IgnoreErrorThreadFactory();
+
+ private IgnoreErrorThreadFactory() {}
+
+ @Override
+ public Thread newThread(@NotNull Runnable r) {
+ Thread thread = new Thread(r);
Review Comment:
Would be better if can refer to the `ExecutorThreadFactory` add the thread group and thread name for your purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20063:
URL: https://github.com/apache/flink/pull/20063#issuecomment-1171097265
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20063:
URL: https://github.com/apache/flink/pull/20063#issuecomment-1168282826
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 merged pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
fsk119 merged PR #20063:
URL: https://github.com/apache/flink/pull/20063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20063:
URL: https://github.com/apache/flink/pull/20063#issuecomment-1165256041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b731645289cc8eaeb3179b373cef8bddf4d3f915",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b731645289cc8eaeb3179b373cef8bddf4d3f915",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b731645289cc8eaeb3179b373cef8bddf4d3f915 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20063:
URL: https://github.com/apache/flink/pull/20063#issuecomment-1170817245
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20063:
URL: https://github.com/apache/flink/pull/20063#issuecomment-1172017385
The failed test in not related to the current change.
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a diff in pull request #20063: [FLINK-28238][sql-gateway] Fix unstable testCancelOperationAndFetchResultInParallel
Posted by GitBox <gi...@apache.org>.
fsk119 commented on code in PR #20063:
URL: https://github.com/apache/flink/pull/20063#discussion_r909475210
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/utils/IgnoreErrorThreadFactory.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.gateway.service.utils;
+
+import org.jetbrains.annotations.NotNull;
+
+import java.util.concurrent.ThreadFactory;
+
+/** Factory to create the thread that ignores error message. */
+public class IgnoreErrorThreadFactory implements ThreadFactory {
+
+ public static final IgnoreErrorThreadFactory INSTANCE = new IgnoreErrorThreadFactory();
+
+ private IgnoreErrorThreadFactory() {}
+
+ @Override
+ public Thread newThread(@NotNull Runnable r) {
+ Thread thread = new Thread(r);
Review Comment:
Thanks to point out the `ExecutorThreadFactory`. I think it's better we can reuse the code rather than introduce a new class that is almost same. So I remove the `IgnoreErrorThreadFactory` and use the `ExecutorThreadFactory` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org