You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/25 15:00:31 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
yuruguo opened a new pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483
### Motivation
We should check the validity of the `--compatibility` and give a more friendly prompt message when set schema compatibility strategy for namespace through `./bin/pulsar-admin namespaces set-schema-compatibility-strategy`.
Currently, the lack of verification for `--compatibility` will directly display the exception, as below:
```
./bin/pulsar-admin namespaces set-schema-compatibility-strategy -c ALWAYS_COMPATIBE tenant1/ns1
java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.common.policies.data.SchemaCompatibilityStrategy.ALWAYS_COMPATIBE
at java.lang.Enum.valueOf(Enum.java:238)
at org.apache.pulsar.common.policies.data.SchemaCompatibilityStrategy.valueOf(SchemaCompatibilityStrategy.java:24)
at org.apache.pulsar.admin.cli.CmdNamespaces$SetSchemaCompatibilityStrategy.run(CmdNamespaces.java:1833)
at org.apache.pulsar.admin.cli.CmdBase.run(CmdBase.java:86)
at org.apache.pulsar.admin.cli.PulsarAdminTool.run(PulsarAdminTool.java:282)
at org.apache.pulsar.admin.cli.PulsarAdminTool.main(PulsarAdminTool.java:329)
```
### Modifications
- Throw `ParameterException` when `IllegalArgumentException` occurs when executing `SchemaCompatibilityStrategy.valueOf()`
### Documentation
Automatically generate doc through code
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-952442350
@merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951076048
/pulsarbot run-failure-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951589113
@eolivelli @k2la @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-952729743
@eolivelli @codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951074923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951589113
@eolivelli @k2la @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951422935
@eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet please take a look, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-953410891
@merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-952729743
@eolivelli @codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-953410891
@merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951074923
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951422935
@eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet please take a look, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-953521488
> Lgtm
>
> @yuruguo you don't need to tag so many people. Github is open to everyone and who has time to do some reviews will be happy to review your code.
>
> If you want you can ping me on slack using DM
I'm sorry to interrupt you, because many PRs I submitted have been in `unreviewed` state or the number of `approved` people (at least two) is not enough for a long time, so I ping many person. I will pay attention to this later.
In addition, thank you very much for telling me the way of communication, I will try to use it later :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12483:
URL: https://github.com/apache/pulsar/pull/12483#issuecomment-952442350
@merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org