You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/08 03:43:42 UTC
[GitHub] [skywalking] sunOnly opened a new issue #8634: [Feature] supports the export of hourly and daily metrics
sunOnly opened a new issue #8634:
URL: https://github.com/apache/skywalking/issues/8634
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
supports the export of hourly and daily metrics
org.apache.skywalking.oap.server.core.analysis.worker.MetricsPersistentWorker Change as follows
org.apache.skywalking.oap.server.core.analysis.worker.MetricsStreamProcessor Change as follows
### Use case
Export metrics reanalysis
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly removed a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly removed a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061449302
> > What do you mean components? I think that is impossible for any system. The only solution is you have kinds of big data platforms generating a report rather than getting data in real time. But in that case, minute level metrics should be better for data analysis.
What do you mean components?
Other user-defined types in HTTP or Dubbo services. Query all metric information in type
exporting hours and days. Don't do the second calculation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061431315
What do you mean components? I think that is impossible for any system. The only solution is you have kinds of big data platforms generating a report rather than getting data in real time. But in that case, minute level metrics should be better for data analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061461278
> Use cases query all entity information of the same component at one time
> You mentioned `component`, I don't know.
HTTP or Dubbo or user-defined type. All measurement information in the query type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061423697
I don't know what do you mean performance is not good. From my understanding, your whole page could be done by a single one-request GraphQL, which should have no performance at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly edited a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly edited a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061411429
> Could you describe the scenario about when do you need this?
The complete metrics information of entities in the dashboard can only be viewed separately. To display the entity metrics information in a table, see the following figure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly edited a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly edited a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061437302
> What do you mean components? I think that is impossible for any system. The only solution is you have kinds of big data platforms generating a report rather than getting data in real time. But in that case, minute level metrics should be better for data analysis.
What do you mean components?
Other user-defined types in HTTP or Dubbo services. Query all metric information in type
exporting hours and days. Don't do the second calculation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061449302
> > What do you mean components? I think that is impossible for any system. The only solution is you have kinds of big data platforms generating a report rather than getting data in real time. But in that case, minute level metrics should be better for data analysis.
What do you mean components?
Other user-defined types in HTTP or Dubbo services. Query all metric information in type
exporting hours and days. Don't do the second calculation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061463975
If you are using this kind of custom feature, it seems out of our SkyWalking's scope. You should know, we recommend you aggregate from minute on your own platform, which is more accurate. The exporting to support `INCREMENT` and `TOTAL`, in hour/day level, these would become very tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061375612
Could you describe the scenario about when do you need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061425347
Could you check https://github.com/apache/skywalking/issues/8634#issuecomment-1061423697? I think we should have a clear answer after this discussion. After all, I just want all features to be on top of reasonable requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061419909
The design of exporting is to make metrics available in 3rd party, so, generally you could build everything else on your own.
What you are doing, I can't say wrong, but strange and special about how to use SkyWalking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061437302
> What do you mean components? I think that is impossible for any system. The only solution is you have kinds of big data platforms generating a report rather than getting data in real time. But in that case, minute level metrics should be better for data analysis.
Endpoint type, exporting hours and days. Don't do the second calculation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061459088
> Use cases query all entity information of the same component at one time
You mentioned `component`, I don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061411429
> Could you describe the scenario about when do you need this?
The complete metrics information of entities in the dashboard can only be viewed separately. To display the entity metrics information in a table, see the following figure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061413352
GraphQL style query protocol is for this. We don't have to export everything for this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061481713
I am going to close this for now, as tagged this as `TBD`. If you have a better proposal, I am willing to discuss it, but right now, your proposal seems close to your private requirements only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061375944
I assigned to you as you checked `Yes I am willing to submit a PR!` and also propose this. You are the first one proposing this kind of exporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061375944
I assigned to you as you checked `Yes I am willing to submit a PR!` and also propose this. You are the first one proposing this kind of exposing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly edited a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly edited a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061430047
> I don't know what do you mean performance is not good. From my understanding, your whole page could be done by a single one-request GraphQL, which should have no performance at all.
Use cases query all entity information of the same component at one time, and different indicator information needs multiple database interactions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061430047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly edited a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly edited a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061468982
> If you are using this kind of custom feature, it seems out of our SkyWalking's scope. You should know, we recommend you aggregate from minute on your own platform, which is more accurate. The exporting to support `INCREMENT` and `TOTAL`, in hour/day level, these would become very tricky.
get,I only subscribe to TOTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #8634:
URL: https://github.com/apache/skywalking/issues/8634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly removed a comment on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly removed a comment on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061430116
> I don't know what do you mean performance is not good. From my understanding, your whole page could be done by a single one-request GraphQL, which should have no performance at all.
Use cases query all entity information of the same component at one time, and different indicator information needs multiple database interactions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061417878
> The complete metrics information of entities in the dashboard can only be viewed separately. To display the entity metrics information in a table, see the following figure
The implementation is OK, but the performance is not good,
Export converts the same entity information into one line, and improves the performance of one-time query results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061424764
> The design of exporting is to make metrics available in 3rd party, so, generally you could build everything else on your own. What you are doing, I can't say wrong, but strange and special about how to use SkyWalking.
Is it reasonable to support hour and day export function positioning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sunOnly commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
sunOnly commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061468982
> If you are using this kind of custom feature, it seems out of our SkyWalking's scope. You should know, we recommend you aggregate from minute on your own platform, which is more accurate. The exporting to support `INCREMENT` and `TOTAL`, in hour/day level, these would become very tricky.
get,I only subscribe to TOTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8634: [Feature] supports the export of hourly and daily metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8634:
URL: https://github.com/apache/skywalking/issues/8634#issuecomment-1061472235
That is why upstream can't accept everything, different team has different agenda and plans, but we need a consistent and widely suitable APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org