You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/17 22:40:01 UTC

[GitHub] [trafficcontrol] ezelkow1 opened a new issue #6672: TC or T3C should check simple retry amount vs # of parents

ezelkow1 opened a new issue #6672:
URL: https://github.com/apache/trafficcontrol/issues/6672


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/tc-slack-request)
   or the Traffic Control Users mailing list (send an email to users-subscribe@trafficcontrol.apache.org to subscribe).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR
       * https://github.com/apache/trafficcontrol/issues
       * https://github.com/apache/trafficcontrol/pulls
   -->
   
   <!-- Do not submit security vulnerabilities or support requests here - see above -->
   ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:
   <!-- delete all those that don't apply -->
   - Traffic Control Cache Config (`t3c`, formerly ORT)
   - Traffic Portal
   
   ## Current behavior:
   <!-- Describe how the current features are insufficient. -->
   Currently it is possible to have a setting of max_simple_retries= or > number of parents. If the object requested is a 404 and unresolvable by any of the parents and the max number >= num_parents, then a 502 will be sent down because all the parents have been exhausted but was still requested to connect to yet another parent.
   
   ## New behavior:
   
   There should be a check done somewhere to either warn, or set a max bounds on max_simple_retry to be num_parents-1 so that we dont inadvertently get 502's being generated
   <!-- Describe how this change would improve Traffic Control -->
   This would provide more reliable err codes and states
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jrushford commented on issue #6672: TC or T3C should check simple retry amount vs # of parents

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #6672:
URL: https://github.com/apache/trafficcontrol/issues/6672#issuecomment-1072355751


   @ezelkow1 This applies to max_unavailable_server_retries as well.  Both settings have a maximum value of 5.  So the check should be num_parents-1 upto a maximum of 5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jrushford commented on issue #6672: TC or T3C should check simple retry amount vs # of parents

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #6672:
URL: https://github.com/apache/trafficcontrol/issues/6672#issuecomment-1072355751


   @ezelkow1 This applies to max_unavailable_server_retries as well.  Both settings have a maximum value of 5.  So the check should be num_parents-1 upto a maximum of 5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jrushford edited a comment on issue #6672: TC or T3C should check simple retry amount vs # of parents

Posted by GitBox <gi...@apache.org>.
jrushford edited a comment on issue #6672:
URL: https://github.com/apache/trafficcontrol/issues/6672#issuecomment-1076764256


   Ran into a situation where MSO only had one origin in the parent.config list.  If there is one origin, do NOT configure simple retry or unavailable retry at all.  These two features require a minimum of two parents.  If you enable them with only one parent every retry will result in a parent lookup failure resulting in an immediate 502 response.  There should be a check to ensure a minimum of two parents.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jrushford commented on issue #6672: TC or T3C should check simple retry amount vs # of parents

Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #6672:
URL: https://github.com/apache/trafficcontrol/issues/6672#issuecomment-1076764256


   Ran into a situation where MSO only had one origin in the parent.config list.  If there is one origin, do NOT configure simple retry or unavailable retry at all.  These two features require a minimum of two parents.  If you enable them with only one parent every retry will result in a parent lookup failure resulting in an immediate 502 response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org