You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by yogidevendra <gi...@git.apache.org> on 2015/12/29 10:52:23 UTC
[GitHub] incubator-apex-malhar pull request: MLHR-1958: Exposing some field...
GitHub user yogidevendra opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/149
MLHR-1958: Exposing some fields from AbstractReconciler as protected
1. Making queues as protected for access in derived classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yogidevendra/incubator-apex-malhar MLHR-1958-AbstractReconciler-protected-fields
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 474f150f13d146e4e8d97b268608bb2ab273af3d
Author: yogidevendra <de...@datatorrent.com>
Date: 2015-12-29T09:49:12Z
Making queues as protected for access in derived classes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1958: Adding getter for d...
Posted by gauravgopi123 <gi...@git.apache.org>.
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/149#discussion_r48622315
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractReconciler.java ---
@@ -187,6 +189,18 @@ public void run()
}
/**
+ * Returns the unmodifiable collection of the tuples on which
+ * processCommittedData has been called in this window. Underlying collection
+ * is cleared at every endWindow() of AbstractReconciler.
+ *
+ * @return done tuples
+ */
+ protected Collection<QUEUETUPLE> getDoneTuples()
+ {
+ return Collections.unmodifiableCollection(doneTuples);
+ }
--- End diff --
Can you give details about the usecase why you need only read view and not write view? Why even read view is required as I think this is internal to operator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1958: Exposing some field...
Posted by chinmaykolhatkar <gi...@git.apache.org>.
Github user chinmaykolhatkar commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/149#discussion_r48531567
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractReconciler.java ---
@@ -73,9 +73,9 @@ public void process(INPUT input)
// this stores the mapping from the window to the list of enqueued tuples
private Map<Long, List<QUEUETUPLE>> currentWindowTuples = Maps.newConcurrentMap();
private Queue<Long> currentWindows = Queues.newLinkedBlockingQueue();
- private Queue<QUEUETUPLE> committedTuples = Queues.newLinkedBlockingQueue();
--- End diff --
Any reason why these are required to be protected?
I believe these fields are very important ones for correct functioning of Reconciler along with correct checkpointing.
By making these protected, we're exposing the overall functionality of of this class to get compromised.
In my opinion, we need a strong case for making this protected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1958 Provide access...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---