You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/15 16:21:30 UTC

[GitHub] [airflow] ashb commented on a change in pull request #14745: Make sure DAGs with tasks in shutdown state do get scheduled

ashb commented on a change in pull request #14745:
URL: https://github.com/apache/airflow/pull/14745#discussion_r594484482



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -3920,6 +3920,50 @@ def test_do_schedule_max_active_runs_task_removed(self):
         ti = run1.get_task_instance(task1.task_id, session)
         assert ti.state == State.QUEUED
 
+    def test_do_schedule_max_active_runs_task_shutdown(self):
+        """Test that tasks in shutdown state don't count as actively running."""

Review comment:
       I'm not so sure about this. While they are in Shutdown state _they are still running_.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org