You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/12/16 09:13:39 UTC
[GitHub] [jena] afs opened a new pull request #1134: JENA-2221: Remove Apache HTTP Client usage
afs opened a new pull request #1134:
URL: https://github.com/apache/jena/pull/1134
This is part 2 of a 2 change. [JENA-2221](https://issues.apache.org/jira/browse/JENA-2221).
Part 1 is #1133 [[JENA-2220](https://issues.apache.org/jira/browse/JENA-2220). This PR is based off that PR.
This part is a single commit that removes the legacy classes from jena-arq and makes Apache HttpClient artifacts scope=runtime (for jsonld-java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1134: JENA-2221: Remove Apache HTTP Client usage
Posted by GitBox <gi...@apache.org>.
afs merged pull request #1134:
URL: https://github.com/apache/jena/pull/1134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #1134: JENA-2221: Remove Apache HTTP Client usage
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #1134:
URL: https://github.com/apache/jena/pull/1134#discussion_r770440409
##########
File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/ctl/Async.java
##########
@@ -18,13 +18,13 @@
package org.apache.jena.fuseki.ctl;
-import org.apache.http.HttpHeaders;
import org.apache.jena.atlas.json.JsonBuilder;
import org.apache.jena.atlas.json.JsonValue;
import org.apache.jena.fuseki.async.AsyncPool;
import org.apache.jena.fuseki.async.AsyncTask;
import org.apache.jena.fuseki.server.DataService;
import org.apache.jena.fuseki.servlets.HttpAction;
+import org.apache.jena.riot.web.HttpNames;
Review comment:
The source code is available :smile:
If it does, it is not in the jena.net.http package which is the only module export.
Even aside from modules, the rest of the code is in `jdk.internal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a change in pull request #1134: JENA-2221: Remove Apache HTTP Client usage
Posted by GitBox <gi...@apache.org>.
rvesse commented on a change in pull request #1134:
URL: https://github.com/apache/jena/pull/1134#discussion_r770375666
##########
File path: jena-arq/src/main/java/org/apache/jena/sparql/exec/http/Service.java
##########
@@ -188,7 +188,7 @@ private static HttpClient chooseHttpClient(String serviceURL, Context context) {
Object client = context.get(httpQueryClient);
if ( client != null ) {
// Check for old HttpClient
- if ( client instanceof org.apache.http.client.HttpClient ) {
+ if ( client.getClass().getName().equals("org.apache.http.client.HttpClient") ) {
LOGGER.warn("Found Apache HttpClient for content symbol "+httpQueryClient+". Jena now uses java.net.http.HttpClient");
Review comment:
Typo `content` -> `context`
##########
File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/ctl/Async.java
##########
@@ -18,13 +18,13 @@
package org.apache.jena.fuseki.ctl;
-import org.apache.http.HttpHeaders;
import org.apache.jena.atlas.json.JsonBuilder;
import org.apache.jena.atlas.json.JsonValue;
import org.apache.jena.fuseki.async.AsyncPool;
import org.apache.jena.fuseki.async.AsyncTask;
import org.apache.jena.fuseki.server.DataService;
import org.apache.jena.fuseki.servlets.HttpAction;
+import org.apache.jena.riot.web.HttpNames;
Review comment:
Does `java.net.http` not have an equivalent set of constants to Apache HTTP Client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #1134: JENA-2221: Remove Apache HTTP Client usage
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #1134:
URL: https://github.com/apache/jena/pull/1134#discussion_r770441471
##########
File path: jena-arq/src/main/java/org/apache/jena/sparql/exec/http/Service.java
##########
@@ -188,7 +188,7 @@ private static HttpClient chooseHttpClient(String serviceURL, Context context) {
Object client = context.get(httpQueryClient);
if ( client != null ) {
// Check for old HttpClient
- if ( client instanceof org.apache.http.client.HttpClient ) {
+ if ( client.getClass().getName().equals("org.apache.http.client.HttpClient") ) {
LOGGER.warn("Found Apache HttpClient for content symbol "+httpQueryClient+". Jena now uses java.net.http.HttpClient");
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org