You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/02/27 12:39:52 UTC

Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.


Bugs: AMBARI-20032
    https://issues.apache.org/jira/browse/AMBARI-20032


Repository: ambari


Description
-------

HDFS service check fails after Stopping one Namenode in HA cluster.
Stop the active Namenode and run HDFS service check, it fails.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 

Diff: https://reviews.apache.org/r/57087/diff/


Testing
-------

mvn clean test


Thanks,

Eugene Chekanskiy


Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.

> On Feb. 27, 2017, 6:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py, line 46
> > <https://reviews.apache.org/r/57087/diff/2/?file=1650406#file1650406line46>
> >
> >     Please make the same change in HDFS 3.0.0.3.0

This changes are in trunk from AMBARI-19289


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166902
-----------------------------------------------------------


On Feb. 27, 2017, 4:19 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 4:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
>     https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166902
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 
<https://reviews.apache.org/r/57087/#comment238992>

    Please make the same change in HDFS 3.0.0.3.0


- Alejandro Fernandez


On Feb. 27, 2017, 4:19 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 4:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
>     https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166888
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 27, 2017, 6:19 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 6:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
>     https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166891
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On Feb. 27, 2017, 11:19 a.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 11:19 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
>     https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/
-----------------------------------------------------------

(Updated Feb. 27, 2017, 4:19 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.


Bugs: AMBARI-20032
    https://issues.apache.org/jira/browse/AMBARI-20032


Repository: ambari


Description
-------

HDFS service check fails after Stopping one Namenode in HA cluster.
Stop the active Namenode and run HDFS service check, it fails.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 

Diff: https://reviews.apache.org/r/57087/diff/


Testing
-------

mvn clean test


Thanks,

Eugene Chekanskiy


Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166857
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py (line 40)
<https://reviews.apache.org/r/57087/#comment238943>

    let's remove commented/obsolete code


- Dmitro Lisnichenko


On Feb. 27, 2017, 2:39 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:39 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
>     https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>