[GitHub] [iceberg] Fokko commented on issue #6798: [Rest Catalog Open API] Usage of "oneof" in the definition

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on issue #6798:
URL: https://github.com/apache/iceberg/issues/6798#issuecomment-1425519691

   Hey @haizhou-zhao thanks for the elaborate explanation, much appreciated.
   
   I ran into the same issue with generating the classes for PyIceberg. I tried to do this using the generator but ran into the same issue that a type can be both a string and an object (or a dictionary in Python world). I ended up generating the code and implementing a custom parser to distinguish between the primitive and complex types. Agreed that having this as an object is nicer because this would also allow us not to have to parse the `fixed[22]` and just have `{'typeId': 'fixed', 'length': 22}`. Changing this is possible, but would be quite a bit endeavor since we would have to keep backward compatibility.
   
   Did you consider relying on the Iceberg library itself for parsing the schema?
   
   Related to https://github.com/apache/iceberg/pull/6672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org