You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/09/11 01:24:07 UTC

[jira] [Created] (HADOOP-8784) Improve IPC.Client's token use

Daryn Sharp created HADOOP-8784:
-----------------------------------

             Summary: Improve IPC.Client's token use
                 Key: HADOOP-8784
                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
             Project: Hadoop Common
          Issue Type: Sub-task
          Components: ipc, security
    Affects Versions: 2.0.0-alpha, 3.0.0
            Reporter: Daryn Sharp
            Assignee: Daryn Sharp


If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475600#comment-13475600 ] 

Hudson commented on HADOOP-8784:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1194 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1194/])
    HADOOP-8784. Improve IPC.Client's token use (daryn) (Revision 1397634)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397634
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452563#comment-13452563 ] 

Daryn Sharp commented on HADOOP-8784:
-------------------------------------

Sending a token to an older insecure cluster is compatible because the older server kicks the client out of SASL mode.
                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475127#comment-13475127 ] 

Hudson commented on HADOOP-8784:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2918 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2918/])
    HADOOP-8784. Improve IPC.Client's token use (daryn) (Revision 1397634)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397634
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8784:
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-alpha
                   3.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I'm committed to trunk and branch-2.  Thanks Owen!
                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468838#comment-13468838 ] 

Hadoop QA commented on HADOOP-8784:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547589/HADOOP-8784.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1554//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1554//console

This message is automatically generated.
                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475177#comment-13475177 ] 

Hudson commented on HADOOP-8784:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2879 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2879/])
    HADOOP-8784. Improve IPC.Client's token use (daryn) (Revision 1397634)

     Result = FAILURE
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397634
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475130#comment-13475130 ] 

Hudson commented on HADOOP-8784:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2856 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2856/])
    HADOOP-8784. Improve IPC.Client's token use (daryn) (Revision 1397634)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397634
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468866#comment-13468866 ] 

Daryn Sharp commented on HADOOP-8784:
-------------------------------------

TestZKFailoverController tests pass for me.  They appear to randomly fail on the build servers.
                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475613#comment-13475613 ] 

Hudson commented on HADOOP-8784:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1225 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1225/])
    HADOOP-8784. Improve IPC.Client's token use (daryn) (Revision 1397634)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397634
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8784:
--------------------------------

    Attachment: HADOOP-8784.patch

Simple alteration of logic to always look for a token.

Note: "spurious" change of {{return call.rpcResponse}} to {{return call.getRpcResult()}} is to eliminate the only warning in the file.
                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473386#comment-13473386 ] 

Owen O'Malley commented on HADOOP-8784:
---------------------------------------

+1 this looks good.
                
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8784) Improve IPC.Client's token use

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8784:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Improve IPC.Client's token use
> ------------------------------
>
>                 Key: HADOOP-8784
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8784
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8784.patch
>
>
> If present, tokens should be sent for all auth types including simple auth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira