You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2022/07/25 08:38:31 UTC

[shardingsphere] branch master updated: Revise ShardingRemoveTokenGeneratorTest (#19522)

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 8b31b0df1fb Revise ShardingRemoveTokenGeneratorTest (#19522)
8b31b0df1fb is described below

commit 8b31b0df1fb1be905e07c8d109ef1cab2343882c
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Mon Jul 25 16:38:25 2022 +0800

    Revise ShardingRemoveTokenGeneratorTest (#19522)
---
 .../rewrite/token/ShardingRemoveTokenGeneratorTest.java      | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ShardingRemoveTokenGeneratorTest.java b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ShardingRemoveTokenGeneratorTest.java
index f17f350ede4..b3117dcc6de 100644
--- a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ShardingRemoveTokenGeneratorTest.java
+++ b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/ShardingRemoveTokenGeneratorTest.java
@@ -32,23 +32,19 @@ public final class ShardingRemoveTokenGeneratorTest {
     
     @Test
     public void assertIsGenerateSQLTokenWithNonSelectStatement() {
-        ShardingRemoveTokenGenerator shardingRemoveTokenGenerator = new ShardingRemoveTokenGenerator();
-        assertFalse(shardingRemoveTokenGenerator.isGenerateSQLToken(mock(InsertStatementContext.class)));
+        assertFalse(new ShardingRemoveTokenGenerator().isGenerateSQLToken(mock(InsertStatementContext.class)));
     }
     
     @Test
     public void assertIsGenerateSQLTokenWithEmptyAggregationDistinctProjections() {
-        ShardingRemoveTokenGenerator shardingRemoveTokenGenerator = new ShardingRemoveTokenGenerator();
         SelectStatementContext selectStatementContext = mock(SelectStatementContext.class, RETURNS_DEEP_STUBS);
-        when(selectStatementContext.getProjectionsContext().getAggregationDistinctProjections().isEmpty()).thenReturn(Boolean.TRUE);
-        assertFalse(shardingRemoveTokenGenerator.isGenerateSQLToken(selectStatementContext));
+        when(selectStatementContext.getProjectionsContext().getAggregationDistinctProjections().isEmpty()).thenReturn(true);
+        assertFalse(new ShardingRemoveTokenGenerator().isGenerateSQLToken(selectStatementContext));
     }
     
     @Test
     public void assertIsGenerateSQLTokenWithNonEmptyAggregationDistinctProjections() {
-        ShardingRemoveTokenGenerator shardingRemoveTokenGenerator = new ShardingRemoveTokenGenerator();
         SelectStatementContext selectStatementContext = mock(SelectStatementContext.class, RETURNS_DEEP_STUBS);
-        when(selectStatementContext.getProjectionsContext().getAggregationDistinctProjections().isEmpty()).thenReturn(Boolean.FALSE);
-        assertTrue(shardingRemoveTokenGenerator.isGenerateSQLToken(selectStatementContext));
+        assertTrue(new ShardingRemoveTokenGenerator().isGenerateSQLToken(selectStatementContext));
     }
 }