You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "tmielke (via GitHub)" <gi...@apache.org> on 2026/09/08 14:08:43 UTC
[PR] CAMEL-24647: Fix flaky JBang IT tests caused by missing cleanup betwen tests [camel]
tmielke opened a new pull request, #26213:
URL: https://github.com/apache/camel/pull/26213
# Description
The JBang IT tests share a singleton container, but `afterEach()` never
stopped background integrations or cleaned up test files. This caused
two independent failures:
1. `BindException` (Address already in use): background routes from one test were still bound to port 8080 when the next test tried to start. Fixed by calling "camel stop" and waiting (via Awaitility) until `"camel ps"` reports no running processes before proceeding.
2. Wrong OpenAPI spec loaded (HTTP 404): tests that call `downloadFile()` or `generateProperties()` leave files in `/home/jbang/` which persist across tests. A stale application.properties with `camel.jbang.open-api `pointing to `petstore-v3.json` caused a subsequent test to load the wrong spec. Fixed by removing all non-hidden files from `/home/jbang/` after each test. The JBang installation baseline is entirely hidden files (`.jbang/, .bashrc, .camel-jbang/`), so this is safe.
Also wraps `assertNoErrors()` in `try/finally` so cleanup always runs even
when log assertions fail.
Co-Authored-By: Claude Opus 4.6 <no...@anthropic.com>
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
# AI-assisted contributions
- [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24647: Fix flaky JBang IT tests caused by missing cleanup betwen tests [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier merged PR #26213:
URL: https://github.com/apache/camel/pull/26213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24647: Fix flaky JBang IT tests caused by missing cleanup betwen tests [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26213:
URL: https://github.com/apache/camel/pull/26213#issuecomment-5589760966
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24647: Fix flaky JBang IT tests caused by missing cleanup betwen tests [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26213:
URL: https://github.com/apache/camel/pull/26213#issuecomment-5589832412
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-it`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 0 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **1 affected modules** (current approach: 0).
<details><summary>:warning: Modules only in Scalpel (1)</summary>
- `camel-jbang-it`
</details>
**Skip-tests mode would test 1 modules** (1 direct + 0 downstream), **skip tests for 0** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (1)</summary>
- `camel-jbang-it`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `dsl/camel-jbang/camel-jbang-it`: 1 test(s) disabled on GitHub Actions
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/34236386137)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org