You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by bn...@apache.org on 2003/01/14 19:35:39 UTC
cvs commit: apr/threadproc/netware proc.c
bnicholes 2003/01/14 10:35:39
Modified: threadproc/netware proc.c
Log:
Always load the NLM detached so that we don't have to wait for it to clean
up when it terminates. Also check for the correct return value for procve()
Revision Changes Path
1.20 +5 -2 apr/threadproc/netware/proc.c
Index: proc.c
===================================================================
RCS file: /home/cvs/apr/threadproc/netware/proc.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- proc.c 7 Jan 2003 00:52:56 -0000 1.19
+++ proc.c 14 Jan 2003 18:35:39 -0000 1.20
@@ -301,7 +301,10 @@
newproc->out = attr->parent_out;
newproc->err = attr->parent_err;
- addr_space = (attr->detached ? 0 : PROC_CURRENT_SPACE) | PROC_LOAD_SILENT;
+ /* attr->detached and PROC_DETACHED do not mean the same thing. attr->detached means
+ * start the NLM in a separate address space. PROC_DETACHED means don't wait for the
+ * NLM to unload by calling wait() or waitpid(), just clean up */
+ addr_space = (attr->detached ? 0 : PROC_CURRENT_SPACE) | PROC_LOAD_SILENT | PROC_DETACHED;
if (attr->currdir) {
char *fullpath = NULL;
@@ -315,7 +318,7 @@
}
if ((newproc->pid = procve(progname, addr_space, (const char**)env, &wire,
- NULL, NULL, 0, NULL, (const char **)args)) == 0) {
+ NULL, NULL, 0, NULL, (const char **)args)) == -1) {
return errno;
}