You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/15 18:01:46 UTC

[GitHub] [cordova-electron] brodybits commented on pull request #156: refactor: remove more platform-centered files & update code

brodybits commented on pull request #156:
URL: https://github.com/apache/cordova-electron/pull/156#issuecomment-658916094


   LGTM, thanks for the edits. I took the liberty to edit the title based on the scope of the updates, feel free to change it back if it is not right.
   
   It looks like some test cases are changed to run with the Cordova test fixture as opposed to platform-centered workflow, did not see any duplicates in the affected files.
   
   Dumb question but I am assuming this would be merged in a squash commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org