You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by ceharris <gi...@git.apache.org> on 2017/12/14 11:21:15 UTC
[GitHub] guacamole-client pull request #221: GUACAMOLE-464: configuration properties ...
GitHub user ceharris opened a pull request:
https://github.com/apache/guacamole-client/pull/221
GUACAMOLE-464: configuration properties from OS environment
Wanted to see how others feel about this feature before spending more time on it. If the concept is agreeable, there's some work to do in updating documentation. Additionally, the start.sh script for the docker container image should probably be revised to take advantage of this feature.
Might also want to consider whether this feature must be enabled by the presence of another environment variable. This would prevent unexpected configuration of extension properties via the environment, with minor additional nuisance factor for using the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soulwing/guacamole-client GUACAMOLE-464
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #221
----
commit 263cbf2331685a999819f7215b660fe70eac07d8
Author: Carl Harris <ce...@vt.edu>
Date: 2017-12-14T11:14:15Z
GUACAMOLE-464: configuration properties from OS environment
----
---
[GitHub] guacamole-client pull request #221: GUACAMOLE-464: configuration properties ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/221
---
[GitHub] guacamole-client pull request #221: GUACAMOLE-464: configuration properties ...
Posted by ceharris <gi...@git.apache.org>.
Github user ceharris commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/221#discussion_r161824830
--- Diff: guacamole-ext/src/main/java/org/apache/guacamole/environment/LocalEnvironment.java ---
@@ -27,6 +27,8 @@
import java.util.HashMap;
import java.util.Map;
import java.util.Properties;
+
+import org.apache.guacamole.properties.BooleanGuacamoleProperty;
--- End diff --
Still trying to tune my style setup for this project. Thanks for catching that.
---
[GitHub] guacamole-client pull request #221: GUACAMOLE-464: configuration properties ...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/221#discussion_r161823935
--- Diff: guacamole-ext/src/main/java/org/apache/guacamole/environment/LocalEnvironment.java ---
@@ -27,6 +27,8 @@
import java.util.HashMap;
import java.util.Map;
import java.util.Properties;
+
+import org.apache.guacamole.properties.BooleanGuacamoleProperty;
--- End diff --
Minor style detail - in general I think we try to keep the import statements groups together and in mostly alphabetical order, and we don't tend to put spaces in between different groups of imports. I don't have a preference one way or the other, but, for consistency's sake, seems like we should stick to that, here.
---