[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4416: fix(config-ui): transformation name is duplicated when upgrading bp

["mintsweet (via GitHub)" <gi...@apache.org>]

mintsweet commented on code in PR #4416:
URL: https://github.com/apache/incubator-devlake/pull/4416#discussion_r1105901861


##########
config-ui/src/error/components/bp-upgrade/use-bp-upgrade.ts:
##########
@@ -90,27 +90,28 @@ export const useBPUpgrade = ({ id, onResetError }: UseBPUpgradeProps) => {
   };
 
   const upgradeScope = async (plugin: string, connectionId: ID, scope: any) => {
+    // get data scope detail
+    const scopeDetail = await getScopeDetail(plugin, connectionId, scope.options);
+    const scopeId = getScopeId(plugin, scopeDetail);
+
     let transformationRule;
 
     if (scope.transformation) {
       // create transfromation template
       transformationRule = await API.createTransformation(plugin, {
         ...scope.transformation,
-        name: `upgrade-${plugin}-${connectionId}-${new Date().getTime()}`,
+        name: `upgrade-${plugin}-${connectionId}-${scopeId}`,

Review Comment:
   You're right, I'll fixed it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org