You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Ivan Kozlov <ik...@hortonworks.com> on 2014/03/03 18:24:56 UTC

Re: Review Request 18193: Hive JDBC driver value is fetched by agent from incorrect property name.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18193/
-----------------------------------------------------------

(Updated March 3, 2014, 5:24 p.m.)


Review request for Ambari and Andrew Onischuk.


Changes
-------

removed old property from json so unittests test the changes.


Bugs: AMBARI-4701
    https://issues.apache.org/jira/browse/AMBARI-4701


Repository: ambari


Description
-------

Hive JDBC driver name should be fetched from javax.jdo.option.ConnectionDriverName property in hive-site rather than redundant hive_jdbc_driver global property.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py c429555 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 9961212 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json f0250d5 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.json 854b8c9 
  ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 93f8247 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json f99821b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json db34e87 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8bebaf7 
  ambari-server/src/test/python/stacks/2.1.1/configs/default.json 562c073 
  ambari-server/src/test/python/stacks/2.1.1/configs/secured.json e4dd536 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 57a2d40 

Diff: https://reviews.apache.org/r/18193/diff/


Testing
-------

unittests passed successfully
Deployed ambari successfully with HDP1 and HDP2 stacks


Thanks,

Ivan Kozlov


Re: Review Request 18193: Hive JDBC driver value is fetched by agent from incorrect property name.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18193/#review35979
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On March 3, 2014, 5:24 p.m., Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18193/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 5:24 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-4701
>     https://issues.apache.org/jira/browse/AMBARI-4701
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hive JDBC driver name should be fetched from javax.jdo.option.ConnectionDriverName property in hive-site rather than redundant hive_jdbc_driver global property.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py c429555 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 9961212 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json f0250d5 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.json 854b8c9 
>   ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 93f8247 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json f99821b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json db34e87 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8bebaf7 
>   ambari-server/src/test/python/stacks/2.1.1/configs/default.json 562c073 
>   ambari-server/src/test/python/stacks/2.1.1/configs/secured.json e4dd536 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 57a2d40 
> 
> Diff: https://reviews.apache.org/r/18193/diff/
> 
> 
> Testing
> -------
> 
> unittests passed successfully
> Deployed ambari successfully with HDP1 and HDP2 stacks
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>