You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/01/29 09:05:05 UTC

[GitHub] wujysh commented on a change in pull request #35: Fix sonar tianyu

wujysh commented on a change in pull request #35: Fix sonar tianyu
URL: https://github.com/apache/incubator-iotdb/pull/35#discussion_r251742407
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java
 ##########
 @@ -261,7 +258,7 @@ public String deletePath(String path) throws PathErrorException {
     }
     cur.getParent().deleteChild(cur.getName());
     cur = cur.getParent();
-    while (cur != null && !cur.getName().equals("root") && cur.getChildren().size() == 0) {
+    while (cur != null && !("root").equals(cur.getName()) && cur.getChildren().size() == 0) {
 
 Review comment:
   `MetadataConstant.ROOT`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services