You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/22 13:59:00 UTC

[jira] [Commented] (AIRFLOW-6880) Do not check task instances for new DAGRuns

    [ https://issues.apache.org/jira/browse/AIRFLOW-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042586#comment-17042586 ] 

ASF GitHub Bot commented on AIRFLOW-6880:
-----------------------------------------

mik-laj commented on pull request #7501: [AIRFLOW-6880] Do not check task instances for new DAGRuns
URL: https://github.com/apache/airflow/pull/7501
 
 
   When I have the following DAG:
   ```
       dag = DAG(dag_id="test_dag", schedule_interval="@once", start_date=days_ago(2))
       DummyOperator(task_id=f"task", dag=dag)
       dag.sync_to_db()
   ```
   and executes the following code:
   ```
   for i in range(1, 1000+1):
       dag.create_dagrun(
           run_id=f"dag-{i}",
           state=State.RUNNING
       )
   ```
   I got the following results
   Before:
   Query count:  4000
   Average time 13983.817 ms
   After:
   Query count:  3000
   Average time: 11499.290 ms
   Diff:
   Query count: -1000 (-25%)
   Average time: 2.484 (-17%)
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Do not check task instances for new DAGRuns
> -------------------------------------------
>
>                 Key: AIRFLOW-6880
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6880
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: scheduler
>    Affects Versions: 1.10.9
>            Reporter: Kamil Bregula
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)